librelist archives

« back to archive

TUIImageView et al

TUIImageView et al

From:
Patrick B. Gibson
Date:
2011-07-30 @ 02:57
 Hey all,  

I've been playing with TwUI in a side project for a few days and it's 
pretty great. Thanks a lot for shipping it!

I have a couple quick questions: Is there some reason TUIImageView takes 
responsibility for getting the current CG context and drawing its image? 
That method causes TUIStrechableImages to not work as you'd expect – in a 
rather un-like-UIKit way.

It's a simple fix and I'd be happy to send a pull request, but that brings
me to my next question: Is the project in a state that you'd like pull 
requests (or issues filed) for little things like this? I see there's 
already been a few accepted, but I'm hesitant to bother if there's a 
private branch with a big 0.2.0 release or something like it just around 
the corner.

Thanks again!  

– Patrick
@patr1ck

Re: [twui] TUIImageView et al

From:
Loren Brichter
Date:
2011-07-30 @ 04:49
Hey Patrick,

A pull request would be most welcome - thanks!  There are no private 
branches for new versions yet.  Once the project hits 1.0, a model like 
that may make sense, but until then we'll keep master pretty flexible.

Loren

On Jul 29, 2011, at 10:57 PM, Patrick B. Gibson wrote:

> Hey all,
> 
> I've been playing with TwUI in a side project for a few days and it's 
pretty great. Thanks a lot for shipping it!
> 
> I have a couple quick questions: Is there some reason TUIImageView takes
responsibility for getting the current CG context and drawing its image? 
That method causes TUIStrechableImages to not work as you'd expect – in a 
rather un-like-UIKit way.
> 
> It's a simple fix and I'd be happy to send a pull request, but that 
brings me to my next question: Is the project in a state that you'd like 
pull requests (or issues filed) for little things like this? I see there's
already been a few accepted, but I'm hesitant to bother if there's a 
private branch with a big 0.2.0 release or something like it just around 
the corner.
> 
> Thanks again!
> 
> – Patrick
> @patr1ck