librelist archives

« back to archive

Retry and error reporting

Retry and error reporting

From:
Darren Boyd
Date:
2012-08-27 @ 23:03
We take full advantage of the retry logic that sidekiq offers.  The
downside of this is that the error also gets reported (to Airbrake, in our
case).

I wonder if there's a good way to ignore errors from sidekiq, when they are
actually retries?

In our case, with Airbrake, we could ignore the error if it was wrapped in
a specific type of StandardError.  I.e., instead of the RetryJobs
middleware always raising the root error, it could raise a
Sidekiq::RetryError (or similar).

Thoughts?

Thanks,
Darren

Re: [sidekiq] Retry and error reporting

From:
Mike Perham
Date:
2012-08-27 @ 23:42
afaik Airbrake does not notify upon errors beyond the first instance
until you have a new deploy or resolve the error manually.

On Mon, Aug 27, 2012 at 4:03 PM, Darren Boyd <dboyd@realgravity.com> wrote:
> We take full advantage of the retry logic that sidekiq offers.  The downside
> of this is that the error also gets reported (to Airbrake, in our case).
>
> I wonder if there's a good way to ignore errors from sidekiq, when they are
> actually retries?
>
> In our case, with Airbrake, we could ignore the error if it was wrapped in a
> specific type of StandardError.  I.e., instead of the RetryJobs middleware
> always raising the root error, it could raise a Sidekiq::RetryError (or
> similar).
>
> Thoughts?
>
> Thanks,
> Darren
>

Re: [sidekiq] Retry and error reporting

From:
Darren Boyd
Date:
2012-08-28 @ 15:50
On Mon, Aug 27, 2012 at 4:42 PM, Mike Perham <mperham@gmail.com> wrote:

> afaik Airbrake does not notify upon errors beyond the first instance
> until you have a new deploy or resolve the error manually.
>

It doesn't send an email, no.  However, the Airbrake "all unresolved
errors" page still shows these errors.

The point is, it seems odd that sidekiq is successfully setting up a
'retry' of a job but still reporting it as an error.  Is a retry really an
error?

Re: [sidekiq] Retry and error reporting

From:
Jake Mack
Date:
2012-08-29 @ 20:05
I personally like that errors that end up as retries show up as errors 
in Airbrake. For intermittent errors that are fixable, we're more likely 
to be able to find and fix them to avoid having to waste time retrying 
them in the future (we do a lot of scraping and DOM changes for A/B 
tests can break scraping inconsistently).

Darren Boyd wrote:
>
> On Mon, Aug 27, 2012 at 4:42 PM, Mike Perham <mperham@gmail.com
> <mailto:mperham@gmail.com>> wrote:
>
> afaik Airbrake does not notify upon errors beyond the first instance
> until you have a new deploy or resolve the error manually.
>
>
> It doesn't send an email, no. However, the Airbrake "all unresolved
> errors" page still shows these errors.
>
> The point is, it seems odd that sidekiq is successfully setting up a
> 'retry' of a job but still reporting it as an error. Is a retry
> really an error?
>