librelist archives

« back to archive

Patch for 1.9.2 to work (by Steve)

Patch for 1.9.2 to work (by Steve)

From:
Devyn Cairns
Date:
2010-08-20 @ 08:48
diff --git a/Rakefile b/Rakefile
index b4513c7..de92c50 100644
--- a/Rakefile
+++ b/Rakefile
@@ -29,6 +29,10 @@ RUBY_SO = Config::CONFIG['RUBY_SO_NAME']
 RUBY_V = Config::CONFIG['ruby_version']
 RUBY_1_9 = (RUBY_V =~ /^1\.9/)

+if RUBY_1_9
+  $: << "."
+end
+
 if ENV['APP']
 %w[dmg icons].each do |subk|
   APP[subk].keys.each do |name|



Also: maybe use 'git format-patch' next time? ;] It includes the necessary
headers to give you credit for the commit.

-- 
    ~devyn

Re: [shoes] Patch for 1.9.2 to work (by Steve)

From:
ashbb
Date:
2010-08-20 @ 13:48
Thank you for the patch.

But why does this `$: << "."` need for ruby 1.9.2?

Is this a bug for ruby 1.9.2? Or did ruby change the spec?

eveel sent me a pull request today:
http://github.com/eveel/shoes/commit/1af4be572001fd1882276fd9c50eb5c51a6272b0

Is that another approach for the same problem? Or it doesn't concern?

Sorry, I don't know anything about ruby 1.9.2.... :(

ashbb

Re: [shoes] Patch for 1.9.2 to work (by Steve)

From:
Steve Klabnik
Date:
2010-08-20 @ 13:49
Ruby changed the spec. I'm not sure how I feel about this patch.

On Fri, Aug 20, 2010 at 9:48 AM, ashbb <ashbbb@gmail.com> wrote:
> Thank you for the patch.
>
> But why does this `$: << "."` need for ruby 1.9.2?
>
> Is this a bug for ruby 1.9.2? Or did ruby change the spec?
>
> eveel sent me a pull request today:
> http://github.com/eveel/shoes/commit/1af4be572001fd1882276fd9c50eb5c51a6272b0
>
> Is that another approach for the same problem? Or it doesn't concern?
>
> Sorry, I don't know anything about ruby 1.9.2.... :(
>
> ashbb
>

Re: [shoes] Patch for 1.9.2 to work (by Steve)

From:
ashbb
Date:
2010-08-20 @ 14:38
Hi all,

After a little googling, I found the following:

- $LOAD_PATH ($:) doesn't include "." from Ruby 1.9.2 to enforce security.
  Try to use Kernel#require_relative method.

Okay, I think `$: << "."` is nice.
But if possible, try to revise with require_relative method.

I'd like to consider about this problem again when I'll try building
WalkAbout with Ruby 1.9.2. ;-)

ashbb