librelist archives

« back to archive

Cleanup & Release

Cleanup & Release

From:
William Martin
Date:
2014-11-20 @ 13:08
Hi,

I am preparing the release of the version 0.3 (3 years after the 0.2 !!!)

#1 It's looks like we have some dead code in the source.
Can you confirm me ?

- daemon.php
  It is code to fork, but the manager do not used it (duplicate code)
  Maybe used by deleted code ? (i.e start/stop worker)

- processor.php class AfterAnswer
   Never call, or i have miss something

#2 Remove of hnu selftest ?
   This command *just* create a temporary phpunit configuration file, i
propose to add this configuration file in the project base code and remove
associated code. So it's more easy to view what is it tested and what is
ignored.
    It's what i do for all extensions published on github.

#3 I am a big noob to update the pear channel. If someone want to help me,
i will give him write access to the github repo which host the channel. For
composer, push a tag on github will create the release entry on packagist.


William MARTIN

Re: [photon.users] Cleanup & Release

From:
Loic d'Anterroches
Date:
2014-11-20 @ 13:18
On 20.11.2014 14:08, William MARTIN wrote:
> Hi,
>
> I am preparing the release of the version 0.3 (3 years after the 0.2 !!!)
>
> #1 It's looks like we have some dead code in the source.
> Can you confirm me ?
>
> - daemon.php
>    It is code to fork, but the manager do not used it (duplicate code)
>    Maybe used by deleted code ? (i.e start/stop worker)
>
> - processor.php class AfterAnswer
>     Never call, or i have miss something
>
> #2 Remove of hnu selftest ?
>     This command *just* create a temporary phpunit configuration file, i
> propose to add this configuration file in the project base code and
> remove associated code. So it's more easy to view what is it tested and
> what is ignored.
>      It's what i do for all extensions published on github.
>
> #3 I am a big noob to update the pear channel. If someone want to help
> me, i will give him write access to the github repo which host the
> channel. For composer, push a tag on github will create the release
> entry on packagist.
>

Given that the code of photon is in /home/loa/Projects/photon/ with the 
subfolder build.
Given that the code of the photon-channel is in 
/home/loa/Projects/photon-channel/ with the subfolder dist which is the 
DOCROOT of the channel website.
You can rebuild the channel using the associated package.sh and maker.php
maker.php is the script creating the channel info. It is a modified 
version of Pirum to link to the test coverage etc.

When I gave you the content of photon-channel you received those 
scritps. package.sh is attached, maker.php is too big (50kb limit on 
librelist), I can send it to you directly if you need it.

loïc

Re: [photon.users] Cleanup & Release

From:
William Martin
Date:
2014-11-20 @ 14:34
Hi Loic,

I have found in my mailbox others scripts.
Any remarks on point 1 and 2 ?

William

On Thu, Nov 20, 2014 at 2:18 PM, Loic d'Anterroches <loic@ceondo.com> wrote:

> On 20.11.2014 14:08, William MARTIN wrote:
>
>> Hi,
>>
>> I am preparing the release of the version 0.3 (3 years after the 0.2 !!!)
>>
>> #1 It's looks like we have some dead code in the source.
>> Can you confirm me ?
>>
>> - daemon.php
>>    It is code to fork, but the manager do not used it (duplicate code)
>>    Maybe used by deleted code ? (i.e start/stop worker)
>>
>> - processor.php class AfterAnswer
>>     Never call, or i have miss something
>>
>> #2 Remove of hnu selftest ?
>>     This command *just* create a temporary phpunit configuration file, i
>> propose to add this configuration file in the project base code and
>> remove associated code. So it's more easy to view what is it tested and
>> what is ignored.
>>      It's what i do for all extensions published on github.
>>
>> #3 I am a big noob to update the pear channel. If someone want to help
>> me, i will give him write access to the github repo which host the
>> channel. For composer, push a tag on github will create the release
>> entry on packagist.
>>
>>
> Given that the code of photon is in /home/loa/Projects/photon/ with the
> subfolder build.
> Given that the code of the photon-channel is in 
/home/loa/Projects/photon-channel/
> with the subfolder dist which is the DOCROOT of the channel website.
> You can rebuild the channel using the associated package.sh and maker.php
> maker.php is the script creating the channel info. It is a modified
> version of Pirum to link to the test coverage etc.
>
> When I gave you the content of photon-channel you received those scritps.
> package.sh is attached, maker.php is too big (50kb limit on librelist), I
> can send it to you directly if you need it.
>
> loïc
>
>


-- 
---------------------------------------------------------
William MARTIN
wysman @NoSpAm@ gmail @DoT@ com

Re: [photon.users] Cleanup & Release

From:
Loic d'Anterroches
Date:
2014-11-21 @ 09:03
Hello William,

fine with me to remove the dead code. It is always better on the long run.

loïc

On 20.11.2014 15:34, William MARTIN wrote:
> Hi Loic,
>
> I have found in my mailbox others scripts.
> Any remarks on point 1 and 2 ?
>
> William
>
> On Thu, Nov 20, 2014 at 2:18 PM, Loic d'Anterroches <loic@ceondo.com
> <mailto:loic@ceondo.com>> wrote:
>
>     On 20.11.2014 14:08, William MARTIN wrote:
>
>         Hi,
>
>         I am preparing the release of the version 0.3 (3 years after the
>         0.2 !!!)
>
>         #1 It's looks like we have some dead code in the source.
>         Can you confirm me ?
>
>         - daemon.php
>             It is code to fork, but the manager do not used it
>         (duplicate code)
>             Maybe used by deleted code ? (i.e start/stop worker)
>
>         - processor.php class AfterAnswer
>              Never call, or i have miss something
>
>         #2 Remove of hnu selftest ?
>              This command *just* create a temporary phpunit
>         configuration file, i
>         propose to add this configuration file in the project base code and
>         remove associated code. So it's more easy to view what is it
>         tested and
>         what is ignored.
>               It's what i do for all extensions published on github.
>
>         #3 I am a big noob to update the pear channel. If someone want
>         to help
>         me, i will give him write access to the github repo which host the
>         channel. For composer, push a tag on github will create the release
>         entry on packagist.
>
>
>     Given that the code of photon is in /home/loa/Projects/photon/ with
>     the subfolder build.
>     Given that the code of the photon-channel is in
>     /home/loa/Projects/photon-__channel/ with the subfolder dist which
>     is the DOCROOT of the channel website.
>     You can rebuild the channel using the associated package.sh and
>     maker.php
>     maker.php is the script creating the channel info. It is a modified
>     version of Pirum to link to the test coverage etc.
>
>     When I gave you the content of photon-channel you received those
>     scritps. package.sh is attached, maker.php is too big (50kb limit on
>     librelist), I can send it to you directly if you need it.
>
>     loïc
>
>
>
>
> --
> ---------------------------------------------------------
> William MARTIN
> wysman @NoSpAm@ gmail @DoT@ com


-- 
Dr Loïc d'Anterroches
Geschäftsführer

Céondo GmbH         | w: www.ceondo.com
Bülsestr. 56        | e: loic@ceondo.com
45896 Gelsenkirchen | t: +49 209 386 19127
Germany             | f: +49 209 386 19126