librelist archives

« back to archive

Caching in nesta-0.9.13 is broken

Caching in nesta-0.9.13 is broken

From:
Rob Westgeest
Date:
2012-03-05 @ 14:58
Hi,

Caching in nesta-0.9.13 is broken. (See stacktrace below).

I'd suspect that settings.public should be replaced by 
settings.public_folder in cache.rb

If there's anything else i can do to contribute ....

--Stacktrace---

NoMethodError - private method `public' called for Nesta::App:Class:


/home/rob/.rvm/gems/ruby-1.9.2-p290/gems/nesta-0.9.13/lib/nesta/cache.rb:97:in`cache_page_path'


/home/rob/.rvm/gems/ruby-1.9.2-p290/gems/nesta-0.9.13/lib/nesta/cache.rb:33:in`cache'

/home/rob/.rvm/gems/ruby-1.9.2-p290/gems/nesta-0.9.13/lib/nesta/app.rb:94:in 
`block in <class:App>'

cheers

Rob

Re: [nesta] Caching in nesta-0.9.13 is broken

From:
Graham Ashton
Date:
2012-03-06 @ 10:18
On 5 Mar 2012, at 14:58, Rob Westgeest wrote:

> Caching in nesta-0.9.13 is broken. (See stacktrace below). 
> I'd suspect that settings.public should be replaced by 
settings.public_folder in cache.rb

I think you might be right; I've made that edit and can get it to run 
without crashing on my machine, but haven't tried deploying to a server 
with a proper production setup (all my sites are on Heroku at the moment).

> If there's anything else i can do to contribute ....

Could you install from gma/master [1] and let me know if caching is 
working again? If it is, I'll package 0.9.14.

Cheers,
Graham

[1] http://nestacms.com/docs/recipes/running-the-latest-code

Re: [nesta] Caching in nesta-0.9.13 is broken

From:
Rob Westgeest
Date:
2012-03-06 @ 11:15

On 03/06/2012 11:18 AM, Graham Ashton wrote:
> Could you install from gma/master [1] and let me know if caching is 
> working again? If it is, I'll package 0.9.14. Cheers, Graham [1] 
> http://nestacms.com/docs/recipes/running-the-latest-codeI'
I'll have a go and let you know

Re: [nesta] Caching in nesta-0.9.13 is broken

From:
Rob Westgeest
Date:
2012-03-06 @ 12:54
Hi Graham,

Thanks.

I have tried and it works in the sense that it is not throwing 
exceptions about 'public' being a private method anymore.

However:

Caching creates links that will only work in simple server setups.

My server is using several rubies using rvm and stand alone passenger 
instances accessed through reverse proxies like so 

http://blog.phusion.nl/2010/09/21/phusion-passenger-running-multiple-ruby-versions/

My nesta instance is running on 127.0.0.1/3001 behind an apache server. 
Caching now generates links like http://127.0.0.1/css/master.css 
breaking all links in the site.

I think i'll leave caching off a little longer ;-)


On 03/06/2012 12:15 PM, Rob Westgeest wrote:
>
> On 03/06/2012 11:18 AM, Graham Ashton wrote:
>> Could you install from gma/master [1] and let me know if caching is
>> working again? If it is, I'll package 0.9.14. Cheers, Graham [1]
>> http://nestacms.com/docs/recipes/running-the-latest-codeI'
> I'll have a go and let you know

Re: [nesta] Caching in nesta-0.9.13 is broken

From:
Graham Ashton
Date:
2012-03-06 @ 17:03
On 6 Mar 2012, at 12:54, Rob Westgeest wrote:

> My nesta instance is running on 127.0.0.1/3001 behind an apache server. 
Caching now generates links like http://127.0.0.1/css/master.css breaking 
all links in the site.

Thanks.

And damn; it shouldn't be doing that. But I think I know what it is...

https://github.com/gma/nesta/issues/103

> I think i'll leave caching off a little longer ;-)

I'd recommend that you stick with 0.9.11 for the moment and turn caching 
back on! (unless you really want to use the yaml or foldable plugins, the 
latest versions of which both require 0.9.13).

--
Graham Ashton
Founder, The Agile Planner
http://theagileplanner.com | @agileplanner | @grahamashton

Re: [nesta] Caching in nesta-0.9.13 is broken

From:
Graham Ashton
Date:
2012-05-14 @ 17:57
On 6 Mar 2012, at 12:54, Rob Westgeest wrote:

> My server is using several rubies using rvm and stand alone passenger 
instances accessed through reverse proxies like so 
http://blog.phusion.nl/2010/09/21/phusion-passenger-running-multiple-ruby-versions/
> 
> My nesta instance is running on 127.0.0.1/3001 behind an apache server. 
Caching now generates links like http://127.0.0.1/css/master.css breaking 
all links in the site.

I wonder whether you could fix this by forwarding the HTTP_HOST header 
received by Nginx/Apache to Passenger? I've added a comment to issue #103 
about how to configure it in Nginx:

https://github.com/gma/nesta/issues/103#issuecomment-5696713

The next version of Nesta will use paths (i.e. /foo) rather than URLs 
(http://hostname/foo) where possible, but it will still need to use 
absolute URLs in the Atom feed (as feed readers don't typically don't 
resolve URLs relative to the site an article was published on).

I'm thinking that my comment on #103 will become the official line on how 
to set the hostname when creating an absolute URL. I'd love to know if 
people are using Nesta in circumstances where that Nginx config (or an 
equivalent approach, for other proxies) comment doesn't cover it...

Cheers,
Graham

--
Graham Ashton
Founder, The Agile Planner
http://theagileplanner.com | @agileplanner | @grahamashton


Re: [nesta] Caching in nesta-0.9.13 is broken

From:
Graham Ashton
Date:
2012-03-05 @ 15:41
On 5 Mar 2012, at 14:58, Rob Westgeest wrote:

> Caching in nesta-0.9.13 is broken. (See stacktrace below). 
> I'd suspect that settings.public should be replaced by 
settings.public_folder in cache.rb

Hmmm, we clearly need some integration tests that actually fire the app up
properly with different settings enabled.

Thanks for reporting it, I'll see if I can take a look at sorting it out 
later. I suspect you're right, and that Sinatra's API has changed and I 
didn't notice.