librelist archives

« back to archive

Contributing fixes (issue 44)

Contributing fixes (issue 44)

From:
Jason Coffin
Date:
2011-04-15 @ 16:56
I have a fix for issue 44 (https://github.com/gma/nesta/issues/44).
What is the process for contributing bug fixes? Just send out a pull
request? Should the commit message contain a particular string, for
example "Closes GH-44"?

Thanks,
Jason

-- 
Jason Coffin
http://jasoncoffin.com
617.869.0609
Twitter: @jasoncoffin, Skype: jasoncof

Re: [nesta] Contributing fixes (issue 44)

From:
Graham Ashton
Date:
2011-04-15 @ 17:31
On 15 Apr 2011, at 17:56, Jason Coffin wrote:

> I have a fix for issue 44 (https://github.com/gma/nesta/issues/44).

Cool.

> What is the process for contributing bug fixes? Just send out a pull
> request?

Thanks for asking. I think it's high time I wrote a developer specific web
page with notes on coding style, etc.

The best thing to do is to put your commit(s) in a separate branch and 
then send a pull request on that branch.

Include tests.

I'll either:

1. Apply it and push,
2. Tweak it a bit and then apply it, or
3. Hold off on applying it if I'm not convinced it's a great idea or need 
to give the whole area some more thought.

I'm well up for discussing possible approaches before you start on 
something to reduce the chances of 3 occurring.

You can always expect the submission of a patch to bump something up my 
priority list, so bugs that I might not have looked at so quickly will get
fixed sooner.

> Should the commit message contain a particular string, for
> example "Closes GH-44"?

Don't worry too much about the commit message; I can re-write it when 
applying a patch. I probably normally put "(fixes #44)" in brackets on the
end of the commit message, so that's the convention (as much as is there 
is one).

I think it's high time 0.9.5 came out (there are two fixes I'd like 
myself) so maybe this'll be the fix that leads to the release...

Cheers,
Graham