librelist archives

« back to archive

Please run pygit2 through valgrind before release

Please run pygit2 through valgrind before release

From:
Han-Wen Nienhuys
Date:
2012-04-30 @ 18:58
Hi there,

I just fixed two pretty serious memory corruption problems in pygit2.

Both were triggered by running

 valgrind --trace-children=yes python setup.py test

Can I suggest that you guys run this on any new code before accepting
a commit to pygit2.c ?

thanks!

-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

Re: [libgit2] Please run pygit2 through valgrind before release

From:
J. David Ibáñez
Date:
2012-05-01 @ 21:27
Hi,


On 30/04/12 20:58, Han-Wen Nienhuys wrote:
> Hi there,
>
> I just fixed two pretty serious memory corruption problems in pygit2.
>

Thanks, I will look at your pull-request soon.


> Both were triggered by running
>
>  valgrind --trace-children=yes python setup.py test
>
> Can I suggest that you guys run this on any new code before accepting
> a commit to pygit2.c ?
>

noted !


> thanks!
>