librelist archives

« back to archive

Question about api in reflog.h

Question about api in reflog.h

From:
Nacho
Date:
2011-08-14 @ 22:21
/**
 * Get the old oid
 *
 * @param entry a reflog entry
 * @return the old oid
 */
GIT_EXTERN(char *) git_reflog_entry_oidold(const git_reflog_entry *entry);

/**
 * Get the new oid
 *
 * @param entry a reflog entry
 * @return the new oid at this time
 */
GIT_EXTERN(char *) git_reflog_entry_oidnew(const git_reflog_entry *entry);

Shouldn't this return a git_oid? If it shouldn't IMHO this should have a
more representative name.

Regards.

-- 
Ignacio Casal Quinteiro

Re: [libgit2] Question about api in reflog.h

From:
schu
Date:
2011-08-16 @ 08:41
On 08/15/2011 12:21 AM, Nacho wrote:
> /**
>  * Get the old oid
>  *
>  * @param entry a reflog entry
>  * @return the old oid
>  */
> GIT_EXTERN(char *) git_reflog_entry_oidold(const git_reflog_entry *entry);
> 
> /**
>  * Get the new oid
>  *
>  * @param entry a reflog entry
>  * @return the new oid at this time
>  */
> GIT_EXTERN(char *) git_reflog_entry_oidnew(const git_reflog_entry *entry);
> 
> Shouldn't this return a git_oid? If it shouldn't IMHO this should have a
> more representative name.

Yeah, much better. I've changed that. Thanks!