librelist archives

« back to archive

git_commit

git_commit

From:
Sakari Jokinen
Date:
2011-03-07 @ 21:47
hi

Would I be horribly wrong to think that reading a git_commit will
result in all ancestors of that commit to be read in one go?
If so: I would guess, i.e., without actually profiling, that it would
be a bit wasteful? Is there any plans on this front?

Couldn't git_commit use just oids for pointing to its parents?

Sakari

Re: [libgit2] git_commit

From:
Vicent Marti
Date:
2011-03-08 @ 15:37
Hey Sakari,

yes, you are right. Right now we load the tree and the parents, which
is disgustingly inefficient. I'm in the process of fixing this as part
of the revision walker revamp.

Cheers,
Vicent Marti



On Mon, Mar 7, 2011 at 11:47 PM, Sakari Jokinen <sakariij@gmail.com> wrote:
> hi
>
> Would I be horribly wrong to think that reading a git_commit will
> result in all ancestors of that commit to be read in one go?
> If so: I would guess, i.e., without actually profiling, that it would
> be a bit wasteful? Is there any plans on this front?
>
> Couldn't git_commit use just oids for pointing to its parents?
>
> Sakari
>