librelist archives

« back to archive

missing git_repository_close

missing git_repository_close

From:
Sakari Jokinen
Date:
2011-03-15 @ 20:55
7064938 libgit2 version 0.10.0, "very disco"

seems to provide the declaration for git_repository_close but omitting
the definition of it.

# grep -r git_repository_close *
include/git2/repository.h:GIT_EXTERN(void)
git_repository_close(git_repository *repo);

Is this just a accidental omission or is there something more deep going on?

Sakari

Re: [libgit2] missing git_repository_close

From:
Vicent Marti
Date:
2011-03-15 @ 23:14
Hey,

nothing deep going on. Just a brainfart on my part: I wanted to export
git_repository_gc, which is completely unrelated to freeing the
repository; this is now fixed in the development branch.

The repository is free'd with `git_repository_close` (that method has
always been there). You can use the GC method to free up some internal
memory if you have loaded too many objects and are running out of
memory.

Cheers,
Vicent Marti



On Tue, Mar 15, 2011 at 10:55 PM, Sakari Jokinen <sakariij@gmail.com> wrote:
> 7064938 libgit2 version 0.10.0, "very disco"
>
> seems to provide the declaration for git_repository_close but omitting
> the definition of it.
>
> # grep -r git_repository_close *
> include/git2/repository.h:GIT_EXTERN(void)
> git_repository_close(git_repository *repo);
>
> Is this just a accidental omission or is there something more deep going on?
>
> Sakari
>