librelist archives

« back to archive

[libgit2] Timezone offset handling

[libgit2] Timezone offset handling

From:
Emeric Fermas
Date:
2010-12-11 @ 15:35
Hello,

A first draft of implementation of timezone offset handling has been
pushed (https://github.com/libgit2/libgit2/pull/27).

Every comment and feedback would be highly appreciated!


Cheers,
Em.

Re: [libgit2] Timezone offset handling

From:
Vicent Marti
Date:
2010-12-11 @ 15:52
Brilliant; I'll be reviewing that in the pull request itself. Thanks as always.

Cheers,
Vicent Marti



On Sat, Dec 11, 2010 at 5:35 PM, Emeric Fermas <emeric.fermas@gmail.com> wrote:
> Hello,
>
> A first draft of implementation of timezone offset handling has been
> pushed (https://github.com/libgit2/libgit2/pull/27).
>
> Every comment and feedback would be highly appreciated!
>
>
> Cheers,
> Em.
>

Re: [libgit2] Timezone offset handling

From:
Emeric Fermas
Date:
2010-12-11 @ 17:10
Just some quick warnings.

-I haven't been able to run the tests. I'm somewhat lost in windows
linker hell. I've made my best to not break anything, but I'm pretty
sure something will fail. I'll be glad to fix any broken test.
-I haven't coded in C for many years (+10). So... well... I'm a bit
rusty and my code may lack some style. Feedback on this side would be
also much appreciated.


Em.



On Sat, Dec 11, 2010 at 4:52 PM, Vicent Marti <tanoku@gmail.com> wrote:
> Brilliant; I'll be reviewing that in the pull request itself. Thanks as always.
>
> Cheers,
> Vicent Marti
>
>
>
> On Sat, Dec 11, 2010 at 5:35 PM, Emeric Fermas <emeric.fermas@gmail.com> wrote:
>> Hello,
>>
>> A first draft of implementation of timezone offset handling has been
>> pushed (https://github.com/libgit2/libgit2/pull/27).
>>
>> Every comment and feedback would be highly appreciated!
>>
>>
>> Cheers,
>> Em.
>>
>