librelist archives

« back to archive

Re: [leiningen] Re: Leiningen Windows Installer

Re: [leiningen] Re: Leiningen Windows Installer

From:
Phil Hagelberg
Date:
2013-06-10 @ 18:14
David Powell writes:

> I notice that the new README recommends Windows users install via
> Chocolatey.

Yeah, it looks someone merged that pull request without any discussion.

I don't have an opinion about Choclatey, but from what you're describing
it looks like the there are still serious issues with that package
specifically, so I've reverted that commit for the time being.

For Unix we link directly to the script and then also link to the
"Packaging" wiki where users of specific package managers can see links
to which package managers offer Leiningen; I think we could keep the
Chocolatey stuff on the wiki too.

The last thing I heard about your installer was that we were waiting for
a bit more feedback before linking to it, but if you've had a good
number of downloads without any bug reports then we can probably include
a link in the readme now. I vaguely recall that the installer isn't tied
to a specific version of Leiningen, so it won't need to be updated for
future releases (unless a dependency is added or something crazy like
that); can you confirm? If so then feel free to open a pull request for
the readme link.

-Phil

Re: [leiningen] Re: Leiningen Windows Installer

From:
Phil Hagelberg
Date:
2013-06-13 @ 00:30
Tom Maynard writes:

> I was blithely unaware of the Windows installer until this thread 
> appeared. Here's a bit of feedback:
>
> It works, and it's far, far easier -- especially for a noob -- and it 
> gets the job done quickly, painlessly, and steps out of the way. It 
> would be hard to find a better tool for Windows types.

Thanks; it's great to get this kind of feedback.

Apparently I goofed up my push for the commit which reverted the
Choclatey mention earlier, but I've just replaced it with a link to
David's installer. Happy to take pull requests to improve the wording
there.

> LEIN_JAVA_CMD is set to point to your selected JDK, and the :java-cmd
> property is set in your user profile in profiles.clj.

I noticed this on the instructions for the Windows
installer. Technically setting both of these shouldn't be necessary;
just `JAVA_CMD` will handle both.

-Phil

Re: [leiningen] Re: Leiningen Windows Installer

From:
David Powell
Date:
2013-06-13 @ 11:06
On Thu, Jun 13, 2013 at 1:30 AM, Phil Hagelberg <phil@hagelb.org> wrote:

>
> > LEIN_JAVA_CMD is set to point to your selected JDK, and the :java-cmd
> > property is set in your user profile in profiles.clj.
>
> I noticed this on the instructions for the Windows
> installer. Technically setting both of these shouldn't be necessary;
> just `JAVA_CMD` will handle both.
>

I was just a bit paranoid about setting JAVA_CMD globally from the
Leiningen installer because there are some other applications that use
JAVA_CMD to override their java path, and I didn't really want to
potentially screw up other apps when Leiningen gets installed (eg - perhaps
another app uses JNI and specifically requires a 32-bit or 64-bit version
of java).

-- 
Dave

Re: [leiningen] Re: Leiningen Windows Installer

From:
Tom Maynard
Date:
2013-06-12 @ 16:55
On 10-Jun-13 13:14, Phil Hagelberg wrote:

> The last thing I heard about your installer was that we were waiting for
> a bit more feedback before linking to it

I was blithely unaware of the Windows installer until this thread 
appeared. Here's a bit of feedback:

It works, and it's far, far easier -- especially for a noob -- and it 
gets the job done quickly, painlessly, and steps out of the way. It 
would be hard to find a better tool for Windows types.

This report comes to you via Windows 8, so it works just fine there.

Re: [leiningen] Re: Leiningen Windows Installer

From:
Phil Hagelberg
Date:
2013-06-13 @ 16:52
David Powell writes:

> I was just a bit paranoid about setting JAVA_CMD globally from the
> Leiningen installer because there are some other applications that use
> JAVA_CMD to override their java path, and I didn't really want to
> potentially screw up other apps when Leiningen gets installed (eg - perhaps
> another app uses JNI and specifically requires a 32-bit or 64-bit version
> of java).

Oh, that's right; I remember now having discussed this. Makes perfect sense.

-Phil