librelist archives

« back to archive

Supported Java Versions

Supported Java Versions

From:
Jan Sorensen
Date:
2012-05-20 @ 21:46
Hi,
John introduced recently ServerPools, they use a BlockingQueue which
was introduced in Java 6. Until then JavaHg would work fine with Java
5.

Personally I'm fine with not supporting Java 5, but I just want to
make sure we agree on that, and don't begin using Java 6 features by
accident.

Rgds,
Jan

Re: [javahg] Supported Java Versions

From:
John Peberdy
Date:
2012-05-20 @ 23:49
On Sun, May 20, 2012 at 5:46 PM, Jan Sorensen <sorensenjan@gmail.com> wrote:
>
> Hi,
> John introduced recently ServerPools, they use a BlockingQueue which
> was introduced in Java 6. Until then JavaHg would work fine with Java
> 5.
>
> Personally I'm fine with not supporting Java 5, but I just want to
> make sure we agree on that, and don't begin using Java 6 features by
> accident.

It was indeed an accident. I used BlockingDeque so I could use it like
a stack so the hottest server were used most often. But I ended up
having the server pool keep at most one unused server so the stack
semantics were unnecessary.

I pushed a change to use BlockingQueue instead of BlockingDeque which
should restore Java 5 compatibility.

I require Java 5 support in general so I'd like for JavaHg to keep 5 support.


>
> Rgds,
> Jan




--
John Peberdy