librelist archives

« back to archive

flask openid version 1.1 changes the import statement needed

flask openid version 1.1 changes the import statement needed

From:
Jason Grout
Date:
2012-11-21 @ 15:19
The other day, I downloaded the flask openid extension on PyPy 
(http://packages.python.org/Flask-OpenID/, version 1.1) and noticed that 
it broke my code (written for version 1.0.1) because it changed the name 
of the import from

import flaskext.openid

to

import flask_openid

I checked the git repository [1], and it doesn't show such a change. 
The online documentation also shows the old import statement.  Was there 
a change that wasn't uploaded to git, or is something wrong with the 
version on PyPy?  I'm curious the reason for the change in the interface 
too.

Thanks,

Jason

[1] https://github.com/mitsuhiko/flask-openid

--
Jason Grout

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Teo Klestrup Röijezon
Date:
2012-11-21 @ 16:08
Note that, since Flask 0.8, you are supposed to use flask.ext.* instead of
flask_* or flaskext.*.


On 21 November 2012 16:19, Jason Grout <jason-sage@creativetrax.com> wrote:

> The other day, I downloaded the flask openid extension on PyPy
> (http://packages.python.org/Flask-OpenID/, version 1.1) and noticed that
> it broke my code (written for version 1.0.1) because it changed the name
> of the import from
>
> import flaskext.openid
>
> to
>
> import flask_openid
>
> I checked the git repository [1], and it doesn't show such a change.
> The online documentation also shows the old import statement.  Was there
> a change that wasn't uploaded to git, or is something wrong with the
> version on PyPy?  I'm curious the reason for the change in the interface
> too.
>
> Thanks,
>
> Jason
>
> [1] https://github.com/mitsuhiko/flask-openid
>
> --
> Jason Grout
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Jason Grout
Date:
2012-11-21 @ 16:21
On 11/21/12 10:08 AM, Teo Klestrup Röijezon wrote:
> Note that, since Flask 0.8, you are supposed to use flask.ext.* instead
> of flask_* or flaskext.*.

Thanks!  That does indeed solve the problem.

I guess I still am curious about the version uploaded to PyPy containing 
changes not in the github repository.  But now I have your fix; thanks!

Jason

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Teo Klestrup Röijezon
Date:
2012-11-21 @ 16:10
Also, the changes seem to be in

https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772baeand

https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
.


On 21 November 2012 17:08, Teo Klestrup Röijezon <teo@nullable.se> wrote:

> Note that, since Flask 0.8, you are supposed to use flask.ext.* instead of
> flask_* or flaskext.*.
>
>
> On 21 November 2012 16:19, Jason Grout <jason-sage@creativetrax.com>wrote:
>
>> The other day, I downloaded the flask openid extension on PyPy
>> (http://packages.python.org/Flask-OpenID/, version 1.1) and noticed that
>> it broke my code (written for version 1.0.1) because it changed the name
>> of the import from
>>
>> import flaskext.openid
>>
>> to
>>
>> import flask_openid
>>
>> I checked the git repository [1], and it doesn't show such a change.
>> The online documentation also shows the old import statement.  Was there
>> a change that wasn't uploaded to git, or is something wrong with the
>> version on PyPy?  I'm curious the reason for the change in the interface
>> too.
>>
>> Thanks,
>>
>> Jason
>>
>> [1] https://github.com/mitsuhiko/flask-openid
>>
>> --
>> Jason Grout
>>
>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Sean Lynch
Date:
2012-11-21 @ 16:26
@Teo - this is odd.  I went to look to see if flask-openid had made a
change and didn't notice anything.  I see those commits you linked, but if
I go to all commits (https://github.com/mitsuhiko/flask-openid/commits/), I
don't see those.  There is only the master branch, and the last commit I
see was 10 months ago (which was to the example, the rest is 2 years old).


On Wed, Nov 21, 2012 at 11:10 AM, Teo Klestrup Röijezon <teo@nullable.se>wrote:

> Also, the changes seem to be in
> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772baeand
> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
> .
>
>
> On 21 November 2012 17:08, Teo Klestrup Röijezon <teo@nullable.se> wrote:
>
>> Note that, since Flask 0.8, you are supposed to use flask.ext.* instead
>> of flask_* or flaskext.*.
>>
>>
>> On 21 November 2012 16:19, Jason Grout <jason-sage@creativetrax.com>wrote:
>>
>>> The other day, I downloaded the flask openid extension on PyPy
>>> (http://packages.python.org/Flask-OpenID/, version 1.1) and noticed that
>>> it broke my code (written for version 1.0.1) because it changed the name
>>> of the import from
>>>
>>> import flaskext.openid
>>>
>>> to
>>>
>>> import flask_openid
>>>
>>> I checked the git repository [1], and it doesn't show such a change.
>>> The online documentation also shows the old import statement.  Was there
>>> a change that wasn't uploaded to git, or is something wrong with the
>>> version on PyPy?  I'm curious the reason for the change in the interface
>>> too.
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> [1] https://github.com/mitsuhiko/flask-openid
>>>
>>> --
>>> Jason Grout
>>>
>>
>>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Jason Grout
Date:
2012-11-21 @ 16:31
On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
> Also, the changes seem to be in
> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
> and
> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c.
>

Interesting: those changes don't show up in the master version, but do 
show up when I select the 1.1 tag on github.  Thanks for pointing that out.

Thanks!

Jason

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Larry Tjoelker
Date:
2012-11-21 @ 18:37
Maybe OpenID-Connect should be mentioned before OpenID is put aside.  
OpenID-Connect is OpenID with OAuth.  Vendors like Google who plan to 
leverage identity may be reluctant to give up the OpenID model, and 
Google-Auth, for example, looks a lot like OpenID-Connect going forward.  
So Flask-OpenID could be relevant for a long time.  

-larry


-----<flask@librelist.com> wrote: -----
To: <flask@librelist.com>
From: Sean Lynch 
Sent by: 
Date: 11/21/2012 08:55AM
Subject: Re: [flask] flask openid version 1.1 changes the import statement	needed

Awe, I see that.  1.1 must have been developed in a different branch that 
was delete and never merged to master.

Btw, on a side note, it seems OpenID has become less favorable for 
external authentication for OAuth.  Jason, you might want to look at using
Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and 
Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of 
Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
of inactivity while Armin has been busy. 


On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout <jason-sage@creativetrax.com> wrote:
 
On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
 > Also, the changes seem to be in
 > 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
 > and
 > 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c.
 >
 
 Interesting: those changes don't show up in the master version, but do
 show up when I select the 1.1 tag on github.  Thanks for pointing that out.
 
 Thanks!
 
 Jason
 
 
 

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Sean Lynch
Date:
2012-11-21 @ 18:46
I assume OpenID-Connect is the "OpenID+OAuth Hybrid protocol" mentioned on
Google's federated login page -
https://developers.google.com/accounts/docs/OpenID.


On Wed, Nov 21, 2012 at 1:37 PM, Larry Tjoelker
<larry_tjoelker@dot.ca.gov>wrote:

> Maybe OpenID-Connect should be mentioned before OpenID is put aside.
>  OpenID-Connect is OpenID with OAuth.  Vendors like Google who plan to
> leverage identity may be reluctant to give up the OpenID model, and
> Google-Auth, for example, looks a lot like OpenID-Connect going forward.
>  So Flask-OpenID could be relevant for a long time.
>
> -larry
>
>
> -----<flask@librelist.com> wrote: -----
> To: <flask@librelist.com>
> From: Sean Lynch
> Sent by:
> Date: 11/21/2012 08:55AM
> Subject: Re: [flask] flask openid version 1.1 changes the import statement
>      needed
>
> Awe, I see that.  1.1 must have been developed in a different branch that
> was delete and never merged to master.
>
> Btw, on a side note, it seems OpenID has become less favorable for
> external authentication for OAuth.  Jason, you might want to look at using
> Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and
> Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of
> Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
> of inactivity while Armin has been busy.
>
>
> On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout <jason-sage@creativetrax.com>
> wrote:
>
> On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
>  > Also, the changes seem to be in
>  >
> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
>  > and
>  >
> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
> .
>  >
>
>  Interesting: those changes don't show up in the master version, but do
>  show up when I select the 1.1 tag on github.  Thanks for pointing that
> out.
>
>  Thanks!
>
>  Jason
>
>
>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Sean Lynch
Date:
2012-11-21 @ 16:51
Awe, I see that.  1.1 must have been developed in a different branch that
was delete and never merged to master.

Btw, on a side note, it seems OpenID has become less favorable for external
authentication for OAuth.  Jason, you might want to look at using
Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and
Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of
Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
of inactivity while Armin has been busy.


On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout
<jason-sage@creativetrax.com>wrote:

> On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
> > Also, the changes seem to be in
> >
> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
> > and
> >
> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
> .
> >
>
> Interesting: those changes don't show up in the master version, but do
> show up when I select the 1.1 tag on github.  Thanks for pointing that out.
>
> Thanks!
>
> Jason
>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Jason Grout
Date:
2012-11-21 @ 17:21
On 11/21/12 10:51 AM, Sean Lynch wrote:
> Awe, I see that.  1.1 must have been developed in a different branch
> that was delete and never merged to master.
>
> Btw, on a side note, it seems OpenID has become less favorable for
> external authentication for OAuth.  Jason, you might want to look at
> using Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth
> and Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork
> of Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a
> long bit of inactivity while Armin has been busy.
>


Thanks for the tips!

Jason

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Smartboy
Date:
2012-11-21 @ 18:19
OpenID and OAuth don't fulfill the same requirements, and shouldn't be
compared (though they often are). OpenID was designed to provide
authentication, whereas OAuth was designed to provide authorization. OpenID
is often used in creating new accounts for users based on an existing
account that they have with an OpenID provider. OAuth, on the other hand,
allows the user to provide access to certain parts of a site under their
name without giving them their password. You should choose between them
based on whether you're trying to do authentication of users or
authorization of third party libraries.

On Wed, Nov 21, 2012 at 8:51 AM, Sean Lynch <techniq35@gmail.com> wrote:

> Awe, I see that.  1.1 must have been developed in a different branch that
> was delete and never merged to master.
>
> Btw, on a side note, it seems OpenID has become less favorable for
> external authentication for OAuth.  Jason, you might want to look at using
> Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and
> Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of
> Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
> of inactivity while Armin has been busy.
>
>
> On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout <jason-sage@creativetrax.com
> > wrote:
>
>> On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
>> > Also, the changes seem to be in
>> >
>> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
>> > and
>> >
>> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
>> .
>> >
>>
>> Interesting: those changes don't show up in the master version, but do
>> show up when I select the 1.1 tag on github.  Thanks for pointing that
>> out.
>>
>> Thanks!
>>
>> Jason
>>
>>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Sean Lynch
Date:
2012-11-21 @ 18:33
@Smartboy - I agree and understand the differences between OpenID/OAuth and
authentication/authorization (and the missing a - accounting), but I also
think OAuth has been used by others to server both authentication and
authorization.  In fact, both Google (
https://developers.google.com/accounts/docs/OAuth2Login) and Facebook (
https://developers.facebook.com/docs/concepts/login/) promote this (I'm not
sure if Facebook still provides OpenID access).

I'm also not sure if all the popular third party providers (Github,
Dropbox, Twitter) support OpenID, but I know they support OAuth 2.0.  It
seems to be a trend now to use OAuth over OpenID, and also allows for
access to other scopes (api) of the provider once access by the user has
been granted (ex. Log into Spotify via Facebook, Spotify can use your
friends to recommend music without having to ask again for authorization.
 While this may be correct to keep them separate, I think it would be
jarring to the end user to have to permit Facebook a second time).


On Wed, Nov 21, 2012 at 1:19 PM, Smartboy <smartboyathome@gmail.com> wrote:

> OpenID and OAuth don't fulfill the same requirements, and shouldn't be
> compared (though they often are). OpenID was designed to provide
> authentication, whereas OAuth was designed to provide authorization. OpenID
> is often used in creating new accounts for users based on an existing
> account that they have with an OpenID provider. OAuth, on the other hand,
> allows the user to provide access to certain parts of a site under their
> name without giving them their password. You should choose between them
> based on whether you're trying to do authentication of users or
> authorization of third party libraries.
>
>
> On Wed, Nov 21, 2012 at 8:51 AM, Sean Lynch <techniq35@gmail.com> wrote:
>
>> Awe, I see that.  1.1 must have been developed in a different branch that
>> was delete and never merged to master.
>>
>> Btw, on a side note, it seems OpenID has become less favorable for
>> external authentication for OAuth.  Jason, you might want to look at using
>> Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and
>> Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of
>> Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
>> of inactivity while Armin has been busy.
>>
>>
>> On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout <
>> jason-sage@creativetrax.com> wrote:
>>
>>> On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
>>> > Also, the changes seem to be in
>>> >
>>> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
>>> > and
>>> >
>>> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
>>> .
>>> >
>>>
>>> Interesting: those changes don't show up in the master version, but do
>>> show up when I select the 1.1 tag on github.  Thanks for pointing that
>>> out.
>>>
>>> Thanks!
>>>
>>> Jason
>>>
>>>
>>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Smartboy
Date:
2012-11-21 @ 19:19
I realize that some big providers use OAuth for logging in, although Google
does also promote OpenID Connect. However, I think this article sums up the
problems with using an authorization protocol for authentication:

http://www.thread-safe.com/2012/01/problem-with-oauth-for-authentication.html

Smartboy

On Wed, Nov 21, 2012 at 10:33 AM, Sean Lynch <techniq35@gmail.com> wrote:

> @Smartboy - I agree and understand the differences between OpenID/OAuth
> and authentication/authorization (and the missing a - accounting), but I
> also think OAuth has been used by others to server both authentication and
> authorization.  In fact, both Google (
> https://developers.google.com/accounts/docs/OAuth2Login) and Facebook (
> https://developers.facebook.com/docs/concepts/login/) promote this (I'm
> not sure if Facebook still provides OpenID access).
>
> I'm also not sure if all the popular third party providers (Github,
> Dropbox, Twitter) support OpenID, but I know they support OAuth 2.0.  It
> seems to be a trend now to use OAuth over OpenID, and also allows for
> access to other scopes (api) of the provider once access by the user has
> been granted (ex. Log into Spotify via Facebook, Spotify can use your
> friends to recommend music without having to ask again for authorization.
>  While this may be correct to keep them separate, I think it would be
> jarring to the end user to have to permit Facebook a second time).
>
>
> On Wed, Nov 21, 2012 at 1:19 PM, Smartboy <smartboyathome@gmail.com>wrote:
>
>> OpenID and OAuth don't fulfill the same requirements, and shouldn't be
>> compared (though they often are). OpenID was designed to provide
>> authentication, whereas OAuth was designed to provide authorization. OpenID
>> is often used in creating new accounts for users based on an existing
>> account that they have with an OpenID provider. OAuth, on the other hand,
>> allows the user to provide access to certain parts of a site under their
>> name without giving them their password. You should choose between them
>> based on whether you're trying to do authentication of users or
>> authorization of third party libraries.
>>
>>
>> On Wed, Nov 21, 2012 at 8:51 AM, Sean Lynch <techniq35@gmail.com> wrote:
>>
>>> Awe, I see that.  1.1 must have been developed in a different branch
>>> that was delete and never merged to master.
>>>
>>> Btw, on a side note, it seems OpenID has become less favorable for
>>> external authentication for OAuth.  Jason, you might want to look at using
>>> Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and
>>> Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of
>>> Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
>>> of inactivity while Armin has been busy.
>>>
>>>
>>> On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout <
>>> jason-sage@creativetrax.com> wrote:
>>>
>>>> On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
>>>> > Also, the changes seem to be in
>>>> >
>>>> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
>>>> > and
>>>> >
>>>> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
>>>> .
>>>> >
>>>>
>>>> Interesting: those changes don't show up in the master version, but do
>>>> show up when I select the 1.1 tag on github.  Thanks for pointing that
>>>> out.
>>>>
>>>> Thanks!
>>>>
>>>> Jason
>>>>
>>>>
>>>
>>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Sean Lynch
Date:
2012-11-21 @ 19:58
Thanks Smartboy.  I've added it to my read list (Pocket) :)


On Wed, Nov 21, 2012 at 2:19 PM, Smartboy <smartboyathome@gmail.com> wrote:

> I realize that some big providers use OAuth for logging in, although
> Google does also promote OpenID Connect. However, I think this article sums
> up the problems with using an authorization protocol for authentication:
>
>
> http://www.thread-safe.com/2012/01/problem-with-oauth-for-authentication.html
>
> Smartboy
>
>
> On Wed, Nov 21, 2012 at 10:33 AM, Sean Lynch <techniq35@gmail.com> wrote:
>
>> @Smartboy - I agree and understand the differences between OpenID/OAuth
>> and authentication/authorization (and the missing a - accounting), but I
>> also think OAuth has been used by others to server both authentication and
>> authorization.  In fact, both Google (
>> https://developers.google.com/accounts/docs/OAuth2Login) and Facebook (
>> https://developers.facebook.com/docs/concepts/login/) promote this (I'm
>> not sure if Facebook still provides OpenID access).
>>
>> I'm also not sure if all the popular third party providers (Github,
>> Dropbox, Twitter) support OpenID, but I know they support OAuth 2.0.  It
>> seems to be a trend now to use OAuth over OpenID, and also allows for
>> access to other scopes (api) of the provider once access by the user has
>> been granted (ex. Log into Spotify via Facebook, Spotify can use your
>> friends to recommend music without having to ask again for authorization.
>>  While this may be correct to keep them separate, I think it would be
>> jarring to the end user to have to permit Facebook a second time).
>>
>>
>> On Wed, Nov 21, 2012 at 1:19 PM, Smartboy <smartboyathome@gmail.com>wrote:
>>
>>> OpenID and OAuth don't fulfill the same requirements, and shouldn't be
>>> compared (though they often are). OpenID was designed to provide
>>> authentication, whereas OAuth was designed to provide authorization. OpenID
>>> is often used in creating new accounts for users based on an existing
>>> account that they have with an OpenID provider. OAuth, on the other hand,
>>> allows the user to provide access to certain parts of a site under their
>>> name without giving them their password. You should choose between them
>>> based on whether you're trying to do authentication of users or
>>> authorization of third party libraries.
>>>
>>>
>>> On Wed, Nov 21, 2012 at 8:51 AM, Sean Lynch <techniq35@gmail.com> wrote:
>>>
>>>> Awe, I see that.  1.1 must have been developed in a different branch
>>>> that was delete and never merged to master.
>>>>
>>>> Btw, on a side note, it seems OpenID has become less favorable for
>>>> external authentication for OAuth.  Jason, you might want to look at using
>>>> Flask-OAuth, and also Flask-Social (which builds upon Flask-OAuth and
>>>> Flask-Security).  Lastly, there is also Flask-Rauth, which is a fork of
>>>> Flask-OAuth, but uses rauth/requests.  Flask-OAuth went through a long bit
>>>> of inactivity while Armin has been busy.
>>>>
>>>>
>>>> On Wed, Nov 21, 2012 at 11:31 AM, Jason Grout <
>>>> jason-sage@creativetrax.com> wrote:
>>>>
>>>>> On 11/21/12 10:10 AM, Teo Klestrup Röijezon wrote:
>>>>> > Also, the changes seem to be in
>>>>> >
>>>>> 
https://github.com/mitsuhiko/flask-openid/commit/33c05305ac0cd68491d73a18e954911b5e772bae
>>>>> > and
>>>>> >
>>>>> 
https://github.com/mitsuhiko/flask-openid/commit/2fc44c5e761ecffafa707946f584688ce7db5e7c
>>>>> .
>>>>> >
>>>>>
>>>>> Interesting: those changes don't show up in the master version, but do
>>>>> show up when I select the 1.1 tag on github.  Thanks for pointing that
>>>>> out.
>>>>>
>>>>> Thanks!
>>>>>
>>>>> Jason
>>>>>
>>>>>
>>>>
>>>
>>
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Sean Lynch
Date:
2012-11-21 @ 16:13
What version of Flask are you using?  And did you try "flask.ext.openid".
 There was a change on how Flask does it's extension importing -
http://flask.pocoo.org/docs/extensions/#flask-before-0-8

Btw, I recommend flask_openid, as I've ran into issues with using the
"flask.ext" hook with Google App Engine (not sure which import hook is at
fault, as both are doing import magic) -
https://github.com/mitsuhiko/flask/blob/master/flask/exthook.py


On Wed, Nov 21, 2012 at 10:19 AM, Jason Grout
<jason-sage@creativetrax.com>wrote:

> The other day, I downloaded the flask openid extension on PyPy
> (http://packages.python.org/Flask-OpenID/, version 1.1) and noticed that
> it broke my code (written for version 1.0.1) because it changed the name
> of the import from
>
> import flaskext.openid
>
> to
>
> import flask_openid
>
> I checked the git repository [1], and it doesn't show such a change.
> The online documentation also shows the old import statement.  Was there
> a change that wasn't uploaded to git, or is something wrong with the
> version on PyPy?  I'm curious the reason for the change in the interface
> too.
>
> Thanks,
>
> Jason
>
> [1] https://github.com/mitsuhiko/flask-openid
>
> --
> Jason Grout
>

Re: [flask] flask openid version 1.1 changes the import statement needed

From:
Jason Grout
Date:
2012-11-21 @ 17:27
On 11/21/12 10:13 AM, Sean Lynch wrote:
> What version of Flask are you using?  And did you try
> "flask.ext.openid".  There was a change on how Flask does it's extension
> importing -http://flask.pocoo.org/docs/extensions/#flask-before-0-8

I'm using Flask 0.9, but apparently we missed that change in how 
extensions were handled in upgrading our codebase.  Thanks for pointing 
out the documentation.


>
> Btw, I recommend flask_openid, as I've ran into issues with using the
> "flask.ext" hook with Google App Engine (not sure which import hook is
> at fault, as both are doing import magic) -
> https://github.com/mitsuhiko/flask/blob/master/flask/exthook.py
>

Thanks for the tips.

Jason