librelist archives

« back to archive

Fwd: RE: Conditionally support subset tags (-DSUBSETTAG) crashes

Fwd: RE: Conditionally support subset tags (-DSUBSETTAG) crashes

From:
Laurence Hygate
Date:
2014-12-12 @ 19:06
-------- Original Message --------
Subject: 	RE: Conditionally support subset tags (-DSUBSETTAG) crashes
Date: 	Fri, 12 Dec 2014 19:01:14 +0000
From: 	Caswick, Kevin <KCaswick@wspackaging.com>
To: 	Laurence Hygate <loz@flower.powernet.co.uk>



Hi Loz,

Apparently what I found is a bug in make check - the t_regress tests are 
picking up the installed version of cvs-fast-export, rather than the 
just built one. Once I installed the fixed version, I was unable to 
reproduce the crash in make check.

I rebuilt and reinstalled the old version, and the issue came back.

Looks like when running make check from the main Makefile, it 
incorrectly sets the path and ends up with a mix of tests using the 
system version and just built version of cvs-fast-export. Apparently 
${PWD} does not refer to the current directory when run from inside make 
-C. Switching it to ${CURDIR} seems to fix the issue.  I made a merge 
request with the Makefile fix: 
https://gitorious.org/cvs-fast-export/cvs-fast-export/merge_requests/107/diffs

Yes, copying the list is fine.

Thanks,

Kevin

*From:*Laurence Hygate [mailto:loz@flower.powernet.co.uk]
*Sent:* Friday, December 12, 2014 11:53 AM
*To:* Caswick, Kevin
*Subject:* Re: Conditionally support subset tags (-DSUBSETTAG) crashes

Kevin

I can't reproduce the core dumps in the test cases. If you could produce 
a stack backtrace, that might help figure out what's going on.

Note, not all the tests pass in my environment, but they don't crash. 
Some of this is because subset tag produces different output than the 
tests expect.

Do you mind if I copy this mail exchange to the mailing list - 
cvsfastexport@librelist.com <mailto:cvsfastexport@librelist.com>

regards

Loz

On 12/12/2014 16:11, Caswick, Kevin wrote:

    Hi Loz,

    That seems to have fixed the crash on my test case, and the module
    that example was pulled from. Diffing the result of checking out the
    branch in git vs. tag in CVS comes out correct too.

    It also fixes the crash on the “twotag” test case that make check
    runs, but I still see core dumps on the t9601 and t9602 test cases
    that make check runs.

    Thanks,

    Kevin

    *From:*Loz [mailto:loz@flower.powernet.co.uk]
    *Sent:* Friday, December 12, 2014 5:22 AM
    *To:* Caswick, Kevin
    *Subject:* Re: Conditionally support subset tags (-DSUBSETTAG) crashes

    Hi Kevin

    Thanks again for the detailed bug report. Turns out to be a silly
    error on my part. A later patch freed some stuff that SUBSETTAG
    depends on.

    I've pushed a fix

    cheers

    Loz

    On 11/12/2014 22:38, Caswick, Kevin wrote:

        Hi Laurence,

        I tested cvs-fast-export with -DSUBSETTAG turned on,
        unfortunately it just core dumps on my repository. Attached is a
        case stripped down to 2 files and 2 versions which is sufficient
        to crash it while running the latest version from the main
        repository.

        I’m not sure if this is a build problem though… does make check
        succeed for you with -DSUBSETTAG? It looks like t9601 and t9602
        are also core dumping for me, and twotag is coming out with an
        empty fastimport stream or crashing and hiding the error message.

        Thanks,

        Kevin

        --
        Kevin L Caswick
        Technical Lead
        WS Packaging Group, Inc.
        2571 S. Hemlock Rd
        Green Bay, WI 54229
        Phone: (920) 866-6417
        Mobile: (920) 217-8841
        Fax: (920) 866-6484
        E-Mail: mailto:kcaswick@wspackaging.com

        ------------------------------------------------------------------------

        - NOTICE -
        This e-mail and its attachment(s) may contain information that
        is privileged, confidential, and/or exempt from disclosure under
        applicable law and is intended solely for the use of the
        individual or entity to which it is addressed. If the reader of
        this message is not the intended recipient, you are hereby
        notified that any disclosure, dissemination, distribution,
        copying, or use of this message is strictly prohibited and may
        be unlawful. If received in error, please notify the sender
        immediately and delete/destroy the message and any copies
        thereof. Although WS Packaging Group, Inc. and/or its affiliates
        (collectively "WS Packaging") attempt to prevent the passage of
        viruses via e-mail and attachments thereto, WS Packaging does
        not guarantee that either are virus-free, and accepts no
        liability for any damage sustained as a result of any such viruses.

    ------------------------------------------------------------------------

    - NOTICE -
    This e-mail and its attachment(s) may contain information that is
    privileged, confidential, and/or exempt from disclosure under
    applicable law and is intended solely for the use of the individual
    or entity to which it is addressed. If the reader of this message is
    not the intended recipient, you are hereby notified that any
    disclosure, dissemination, distribution, copying, or use of this
    message is strictly prohibited and may be unlawful. If received in
    error, please notify the sender immediately and delete/destroy the
    message and any copies thereof. Although WS Packaging Group, Inc.
    and/or its affiliates (collectively "WS Packaging") attempt to
    prevent the passage of viruses via e-mail and attachments thereto,
    WS Packaging does not guarantee that either are virus-free, and
    accepts no liability for any damage sustained as a result of any
    such viruses.

------------------------------------------------------------------------
- NOTICE -
This e-mail and its attachment(s) may contain information that is 
privileged, confidential, and/or exempt from disclosure under applicable 
law and is intended solely for the use of the individual or entity to 
which it is addressed. If the reader of this message is not the intended 
recipient, you are hereby notified that any disclosure, dissemination, 
distribution, copying, or use of this message is strictly prohibited and 
may be unlawful. If received in error, please notify the sender 
immediately and delete/destroy the message and any copies thereof. 
Although WS Packaging Group, Inc. and/or its affiliates (collectively 
"WS Packaging") attempt to prevent the passage of viruses via e-mail and 
attachments thereto, WS Packaging does not guarantee that either are 
virus-free, and accepts no liability for any damage sustained as a 
result of any such viruses.