librelist archives

« back to archive

duplicate messages

duplicate messages

From:
Justin Stefani
Date:
2014-11-04 @ 16:10
I've recently integrated with the master-branch and I've noticed that some
of the outbound chat messages are being received twice. This has been
observed using a converse to converse conversion, and converse to another
chat client. Has anyone else experienced this?

Re: [conversejs] duplicate messages

From:
Jc Brand
Date:
2014-11-06 @ 07:25

On 04 November 2014 5:10:08 nm. CET, Justin Stefani 
<jstefani@thinkingphones.com> wrote:
>I've recently integrated with the master-branch and I've noticed that
>some
>of the outbound chat messages are being received twice. This has been
>observed using a converse to converse conversion, and converse to
>another
>chat client. Has anyone else experienced this?

I noticed something like this with "keepalive: true". When sending out a 
message and then immediately reloading the page from where the message was
sent, the message was sent again.

Under which circumstances do you get duplicate messages?

I thought this was already fixed by checking the IDs of received messages 
and not showing a received message if we already have a message with that 
ID, but perhaps there is still a bug there.

-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Re: [conversejs] duplicate messages

From:
Jc Brand
Date:
2014-11-08 @ 14:57
On Thu, Nov 06, 2014 at 11:41:32AM -0500, Justin Stefani wrote:
>    I have not noticed any pattern to this issue. It does not occur 100%
>    percent of the time, but closer to 30%. There is roughly a 0.5 second
>    delay between the two packets. 
>    Thanks.

Should be fixed now by this commit:


https://github.com/jcbrand/converse.js/commit/dc31057cb9ff6179725823e8b85466c42705f5eb