librelist archives

Re: [homebrew] updating gdb-pixbuf to 2.23.5

From:

Philippe Strauss

Date:

2011-07-19 @ 20:30

Thanks Charlie, now I've pushed my little gdk-pixbuf mod in my fork, name 
zorglub421

Is this email enough to act as a pull request ?

regards.

Le 18 juil. 2011 à 19:41, Charlie Sharpsteen a écrit :

> On Mon, Jul 18, 2011 at 10:25 AM, Philippe Strauss <philou@philou.ch> wrote:
> hello homebrew devs,
> 
> thanks for this simple and effective package management for OSX, I'm now
using it on 10.7.
> 
> 10.7 ships with libpng > 1.5, which trigger a bug in gdk-pixbuf 2.22.1, 
see #6442.
> 
> I've done a brew edit locally to update gdk-pixbuff to 2.23.5 which now 
works fine on my system.
> 
> I've just forked on github, name zorglub421.
> 
> trying to push, however, gives:
> 
> philou@bookpro-wlan:/usr/local$ git push git@github.com:zorglub421/homebrew.git
> Permission denied (publickey).
> fatal: The remote end hung up unexpectedly
> 
> should I push an ssh public key first ?? how do I procede ?
> 
> thanks
> 
> The short version (for command line veterans) is:
> 
>   - Create a SSH key.
>   - Copy the public key to your Account Settings page in GitHub (link is
usually in the upper right corner).
>   - Load the SSH key into ssh-agent whenever you want to move things up 
to GitHub.
>   - Push away.
> 
> 
> If that made absolutely no sense, the GitHub guys do a much better job 
of explaining at:
> 
>     http://help.github.com/mac-set-up-git
> 
> For general questions concerning GitHub usage, be sure to check out 
http://help.github.com.
> 
> Hope this helps!
> 
> -Charlie

On Tue, Jul 19, 2011 at 1:30 PM, Philippe Strauss <philou@philou.ch> wrote:

> Thanks Charlie, now I've pushed my little gdk-pixbuf mod in my fork, name
> zorglub421
>
> Is this email enough to act as a pull request ?
>

Probably not. For a smaller project an email would be enough---but Homebrew
gets so many pull requests that they are unlikely to be reviewed and
integrated unless formally logged in the issue tracker.



> regards.
>

The standard procedure is to commit the changes on a new branch and push it
to your fork. Then go to the page for your fork on GitHub and switch to the
new branch using the "Switch Branches" menu on the left hand side. Finally,
hit the "Pull Request" button on the right side to initiate the pull
request.

A separate branch is used so that your master branch may continue
to receive changes via `brew update` without the history becoming messy.

-Charlie