librelist archives

« back to archive

Pull Request for mplayer, dvdbackup and renameutils

Pull Request for mplayer, dvdbackup and renameutils

From:
James Bunton
Date:
2011-06-19 @ 14:54
Hi,

I have three commits that I've made which I think would be useful for others:

commit a782b6b17e1b0156d3b7784ee21a0565d17ec2b3
Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
Date:   Mon Jun 20 00:22:00 2011 +1000

    renameutils needs coreutils to work

commit 3a75fec2a5da0eb2806fc21c5b7e9c30adc249da
Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
Date:   Mon Jun 6 21:34:34 2011 +1000

    Build mplayer with X11. Now fontconfig and ass work

commit e9f3d0ac552c837afc0299ed99f59b06ab54fc38
Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
Date:   Mon Jun 6 21:32:15 2011 +1000

    Fixed libdvdread to build with dvdbackup


---

James

Re: [homebrew] Pull Request for mplayer, dvdbackup and renameutils

From:
Mike McQuaid
Date:
2011-06-22 @ 16:57
On 19 Jun 2011, at 15:54, James Bunton wrote:

> I have three commits that I've made which I think would be useful for others:

Where are they? Google doesn't help me find them...

--
Mike McQuaid
http://mikemcquaid.com

Re: [homebrew] Pull Request for mplayer, dvdbackup and renameutils

From:
James Bunton
Date:
2011-06-23 @ 22:53
On Wed, Jun 22, 2011 at 05:57:29PM +0100, Mike McQuaid wrote:
> 
> On 19 Jun 2011, at 15:54, James Bunton wrote:
> 
> > I have three commits that I've made which I think would be useful for others:
> 
> Where are they? Google doesn't help me find them...

Oh oops =$

http://delx.net.au/git/homebrew

Sorry about that! Thanks. I can rebase to head again if you like?

---

James

Re: [homebrew] Pull Request for mplayer, dvdbackup and renameutils

From:
Mike McQuaid
Date:
2011-06-25 @ 09:58
On 23 Jun 2011, at 23:53, James Bunton wrote:

> Oh oops =$
> 
> http://delx.net.au/git/homebrew
> 
> Sorry about that! Thanks. I can rebase to head again if you like?

Please make a Github pull request if you want us to merge these.

--
Mike McQuaid
http://mikemcquaid.com

Re: [homebrew] Pull Request for mplayer, dvdbackup and renameutils

From:
Mike McQuaid
Date:
2011-06-20 @ 08:45
On 19 Jun 2011, at 15:54, James Bunton wrote:

> commit a782b6b17e1b0156d3b7784ee21a0565d17ec2b3
> Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
> Date:   Mon Jun 20 00:22:00 2011 +1000
> 
>    renameutils needs coreutils to work

I hate the word "work". What fails with renameutils exactly without coreutils?

> commit e9f3d0ac552c837afc0299ed99f59b06ab54fc38
> Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
> Date:   Mon Jun 6 21:32:15 2011 +1000
> 
>    Fixed libdvdread to build with dvdbackup

How was it fixed?

--
Mike McQuaid
http://mikemcquaid.com

Re: [homebrew] Pull Request for mplayer, dvdbackup and renameutils

From:
James Bunton
Date:
2011-06-20 @ 08:58
On Mon, Jun 20, 2011 at 09:45:33AM +0100, Mike McQuaid wrote:
> 
> On 19 Jun 2011, at 15:54, James Bunton wrote:
> 
> > commit a782b6b17e1b0156d3b7784ee21a0565d17ec2b3
> > Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
> > Date:   Mon Jun 20 00:22:00 2011 +1000
> > 
> >    renameutils needs coreutils to work
> 
> I hate the word "work". What fails with renameutils exactly without
> coreutils?

It doesn't function at all. It seems to fork() and exec() these
commands: ls, mv cp.
It expects them to take GNU style arguments that OSX's BSD commands
don't accept, and so it fails to do anything.
The patch I added makes it depend on coreutils and call gls, gmv and gcp
instead.


> > commit e9f3d0ac552c837afc0299ed99f59b06ab54fc38
> > Author: James Bunton <James Bunton jamesbunton@fastmail.fm>
> > Date:   Mon Jun 6 21:32:15 2011 +1000
> > 
> >    Fixed libdvdread to build with dvdbackup
> 
> How was it fixed?

I added this patch:
	http://dvdbackup.sourceforge.net/DVDFileStat.patch
It doesn't remove or modify any existing functions, and only adds one
function and one struct so it shouldn't break anything.

Thanks for looking at it :)

---

James