librelist archives

« back to archive

request for comments on git-annex formula

request for comments on git-annex formula

From:
Jd Harrington
Date:
2011-03-31 @ 18:59
Hi all,

I put together a formula for git-annex this morning for myself and
would of course like to contribute it to Homebrew. I contributed a
couple of formulae early on, but it's been awhile, so I'm
familiarizing myself with the current standards and would like to ask
for comments on this.

Here's the formula I wrote today:
https://github.com/psi/homebrew/commit/e5d940b505ea456f994447b96b446fe313792a87

The dependencies for git-annex are pretty hefty, and are the primary
concern of my question :)

In addition to deps met by Homebrew, git-annex requires some Haskell
dependencies be installed via cabal before it can build.
It looks the way this is handled for Ruby/Python/Perl/JRuby is with
external dependencies, such as "depends_on 'cucumber' => :jruby" from
the Redcar formula.

Is this the preferred way of handling this situation? It looks
reasonably straightforward to add support for Haskell/cabal
dependencies, so if that's the way forward, I'm happy to do so.

Thanks!

JD

Re: [homebrew] request for comments on git-annex formula

From:
Carter Schonwald
Date:
2011-03-31 @ 20:32
off hand I'd say the dependencies should be fixed just to check if haskell
et al are installed, because the brew install formula isn't current
i've made several remarks as comments on the linked commit, in particular
some of the adjustments (ignoring the dependency mass) are incredibly
fragile

On Thu, Mar 31, 2011 at 2:59 PM, JD Harrington <psi@y0ru.net> wrote:

> Hi all,
>
> I put together a formula for git-annex this morning for myself and
> would of course like to contribute it to Homebrew. I contributed a
> couple of formulae early on, but it's been awhile, so I'm
> familiarizing myself with the current standards and would like to ask
> for comments on this.
>
> Here's the formula I wrote today:
>
> https://github.com/psi/homebrew/commit/e5d940b505ea456f994447b96b446fe313792a87
>
> The dependencies for git-annex are pretty hefty, and are the primary
> concern of my question :)
>
> In addition to deps met by Homebrew, git-annex requires some Haskell
> dependencies be installed via cabal before it can build.
> It looks the way this is handled for Ruby/Python/Perl/JRuby is with
> external dependencies, such as "depends_on 'cucumber' => :jruby" from
> the Redcar formula.
>
> Is this the preferred way of handling this situation? It looks
> reasonably straightforward to add support for Haskell/cabal
> dependencies, so if that's the way forward, I'm happy to do so.
>
> Thanks!
>
> JD
>