librelist archives

« back to archive

Move "grep" to duplicates?

Move "grep" to duplicates?

From:
Adam Vandenberg
Date:
2010-09-25 @ 16:31
Just noticed/remembered (ie, got a pull request for) that there's a
formula for "grep" in mxcl/master. This is quite obviously a system
duplicate; should it be moved to the duplicates branch? Or just
grandfathered in?

There have been several requests to bump it to 2.7; I don't want to
break system stuff/compiles by going to a newer version, but if it's
safe then it's safe.

Re: [homebrew] Move "grep" to duplicates?

From:
Max Howell
Date:
2010-09-25 @ 16:54
It was always a mistake that I pulled that in the first place. But
once stuff is there, it's tricky to remove it. However, what the hell?

> Just noticed/remembered (ie, got a pull request for) that there's a
> formula for "grep" in mxcl/master. This is quite obviously a system
> duplicate; should it be moved to the duplicates branch? Or just
> grandfathered in?
>
> There have been several requests to bump it to 2.7; I don't want to
> break system stuff/compiles by going to a newer version, but if it's
> safe then it's safe.

Re: [homebrew] Move "grep" to duplicates?

From:
Mike McQuaid
Date:
2010-09-25 @ 18:53
On 25 Sep 2010, at 17:54, Max Howell wrote:

> It was always a mistake that I pulled that in the first place. But
> once stuff is there, it's tricky to remove it. However, what the hell?

I'm with removing it. It's easy for people to maintain their own branches 
or use the duplicate branch, I don't think we should worry too much about 
being merciless about the main branch.

--
Cheers,
Mike McQuaid
http://mikemcquaid.com


Re: [homebrew] Move "grep" to duplicates?

From:
Max Howell
Date:
2010-09-25 @ 18:56
Indeed. It's not as though we're removing Ruby, or ImageMagick or
stuff like that. It is just grep. System grep is surely not
significantly different to this one.

Still I maintain we should only cautiously remove stuff that is
already there. Homebrew is pretty massive now. People expect it to be
reliable. Once we start losing their faith, there is no getting it
back.

>> It was always a mistake that I pulled that in the first place. But
>> once stuff is there, it's tricky to remove it. However, what the hell?
>
> I'm with removing it. It's easy for people to maintain their own 
branches or use the duplicate branch, I don't think we should worry too 
much about being merciless about the main branch.

Re: [homebrew] Move "grep" to duplicates?

From:
Mike McQuaid
Date:
2010-09-25 @ 19:01
On 25 Sep 2010, at 19:56, Max Howell wrote:

> Indeed. It's not as though we're removing Ruby, or ImageMagick or
> stuff like that. It is just grep. System grep is surely not
> significantly different to this one.

Agreed.

> Still I maintain we should only cautiously remove stuff that is
> already there. Homebrew is pretty massive now. People expect it to be
> reliable. Once we start losing their faith, there is no getting it
> back.

Also agreed. You're probably more cautious than me about stuff like this 
and that's a good thing.

--
Cheers,
Mike McQuaid
http://mikemcquaid.com