librelist archives

Re: [homebrew] Re: Can I be a collaborator?

From:

Adam Vandenberg

Date:

2010-11-15 @ 21:01

On Sun, Nov 14, 2010 at 11:32 PM, Tianyi Cui <tianyicui@gmail.com> wrote:
> It's been two weeks now. In this induction period, I've done following
> things:
> * integrate my previous work on the LLVM formula (670ad402)
> * new formulae: jacl, ats-lang-anairiats, clozure-cl.
> * make `brew install r` work out of the box (e217aa54)
> * a sbcl 1.0.43 formula without downloading binary from 3rd party (3f0e95d6)
> * minor updates for formulae: gfortran, swi-prolog, plt-racket.
> * sign-off a user-contributed formula: mit-scheme and fix its build error.
> * make all GitHub links in formulae use https (41ab9eec)
> * make all depends_on of "cmake" be marked as :build (a921062d)
> * rebase my tree everyday based on mxcl/master to make sure it can be merged
> cleanly.
> * make sure my tree can be rebased on mxcl/refactor with little conflicts
> (tianyicui/refactor).
> Please review my commits (see also: GitHub Compare View). Thanks.
> On Wed, Nov 3, 2010 at 11:34 PM, Max Howell <max@methylblue.com> wrote:
>>
>> Hey Tianyi,
>>
>> You sound extremely qualified and your areas of expertise sound especially
>> useful. We have discussed how to introduce new collaborators and have
>> decided the healthiest choice for the project is to give you a two week
>> induction period where we review your collaborative efforts and give advice
>> as necessary as to Homebrew style. After this period we'll add you as a
>> collaborator and just ask that you take care while you get to grips with
>> being such an important member of the project.
>>
>> During the induction period please cherry-pick or rebase contributions
>> into your master branch and keep them rebased on top of mxcl/master. We'll
>> merge in your contributions after review.
>>
>> Thanks and welcome to the team! :)
>>
>> Max
>>
>> PS. Do you have a Twitter alias?
>>
>> Hello everyone, esp. Max & Adam,
>> I'm Tianyi Cui (github). I want to be a collaborator of Homebrew, so I can
>> contribute to it more.
>> My background:
>> 1. I'm a college student, my academic interests are compilers and
>> programming languages (esp. functional ones), that means I have a working
>> knowledge on software like LLVM, Clang, Lisp (various dialects),
>> Haskell, OCaml, etc.
>> 2. I've been actively contributing to Homebrew in the previous weeks. In
>> fact, I'm very likely being the one who issue the greatest numbers of pull
>> requests 2.0 to it (disclaimer: I haven't really been counting the number).
>> 3. Any questions related to my abilities/background are welcome.
>> My plan:
>> 1. I'm going to continue to contribute mainly on formulae related to my
>> academic fields, e.g. libsigsegv, clisp, newlisp, libffi, llvm/clang,
>> hugs98, ats-lang-anairiats.
>> 2. I'm going to help review new/updated formulae in pull requests. At
>> least at the beginning, I will only sign off the simple and trivial ones,
>> e.g. 2587, 2588, 2658, 2683, 2694, 2699, 2670.
>> 3. I'm not especially interested in improving homebrew core. If I have any
>> patch against Library/Homebrew, and bin/brew, I won't commit directly. I'll
>> issue pull requests like previously, e.g. this and this, for you guys to
>> review and sign off.
>> 4. Any other responsibilities/plans of me are open to discuss.
>> I really hope I can be a collaborator of Homebrew. It's my honor to help
>> make Homebrew, the most forked software in GitHub, a great example of open
>> source collaboration, better and better day to day! Thanks.
>>
>> --
>> Best Regards,
>> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
>> tianyicui@gmail.com
>> +86 13958103659 (It's a prime number!)
>> http://www.google.com/profiles/tianyicui
>>
>
>
>
> --
> Best Regards,
> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> tianyicui@gmail.com
> +86 13958103659 (It's a prime number!)
> http://www.google.com/profiles/tianyicui
>

I'll try to look at this when I get a chance.
What may be helpful is for you to create a new branch called
"ready-to-merge" (or something like that), and keep those updates you
think are ready to go specifically in that branch, and keep it rebased
against master.

For bigger changes, those need to stay in separate branches for now;
for instance, I haven't had time to review the LLVM changes, but I
also don't feel comfortable reviewing them since I personally don't
build LLVM from source.

So I guess make the "ready-to-merge" branch with the less
controversial changes and I'll work through them (and comment) as I
get time.

Thanks for your patience.

Homebrew is getting more and more pull requests these days. And it seems all
the burden of review and sign-off them is on Adam currently. I really want
to devote my time and help (of course only the simple and trivial ones at
the beginning). Could we speed up the process of introducing me as a
collaborator a little bit? Thanks.

On Tue, Nov 16, 2010 at 5:01 AM, Adam Vandenberg <flangy@gmail.com> wrote:

> On Sun, Nov 14, 2010 at 11:32 PM, Tianyi Cui <tianyicui@gmail.com> wrote:
> > It's been two weeks now. In this induction period, I've done following
> > things:
> > * integrate my previous work on the LLVM formula (670ad402)
> > * new formulae: jacl, ats-lang-anairiats, clozure-cl.
> > * make `brew install r` work out of the box (e217aa54)
> > * a sbcl 1.0.43 formula without downloading binary from 3rd party
> (3f0e95d6)
> > * minor updates for formulae: gfortran, swi-prolog, plt-racket.
> > * sign-off a user-contributed formula: mit-scheme and fix its build
> error.
> > * make all GitHub links in formulae use https (41ab9eec)
> > * make all depends_on of "cmake" be marked as :build (a921062d)
> > * rebase my tree everyday based on mxcl/master to make sure it can be
> merged
> > cleanly.
> > * make sure my tree can be rebased on mxcl/refactor with little conflicts
> > (tianyicui/refactor).
> > Please review my commits (see also: GitHub Compare View). Thanks.
> > On Wed, Nov 3, 2010 at 11:34 PM, Max Howell <max@methylblue.com> wrote:
> >>
> >> Hey Tianyi,
> >>
> >> You sound extremely qualified and your areas of expertise sound
> especially
> >> useful. We have discussed how to introduce new collaborators and have
> >> decided the healthiest choice for the project is to give you a two week
> >> induction period where we review your collaborative efforts and give
> advice
> >> as necessary as to Homebrew style. After this period we'll add you as a
> >> collaborator and just ask that you take care while you get to grips with
> >> being such an important member of the project.
> >>
> >> During the induction period please cherry-pick or rebase contributions
> >> into your master branch and keep them rebased on top of mxcl/master.
> We'll
> >> merge in your contributions after review.
> >>
> >> Thanks and welcome to the team! :)
> >>
> >> Max
> >>
> >> PS. Do you have a Twitter alias?
> >>
> >> Hello everyone, esp. Max & Adam,
> >> I'm Tianyi Cui (github). I want to be a collaborator of Homebrew, so I
> can
> >> contribute to it more.
> >> My background:
> >> 1. I'm a college student, my academic interests are compilers and
> >> programming languages (esp. functional ones), that means I have a
> working
> >> knowledge on software like LLVM, Clang, Lisp (various dialects),
> >> Haskell, OCaml, etc.
> >> 2. I've been actively contributing to Homebrew in the previous weeks. In
> >> fact, I'm very likely being the one who issue the greatest numbers of
> pull
> >> requests 2.0 to it (disclaimer: I haven't really been counting the
> number).
> >> 3. Any questions related to my abilities/background are welcome.
> >> My plan:
> >> 1. I'm going to continue to contribute mainly on formulae related to my
> >> academic fields, e.g. libsigsegv, clisp, newlisp, libffi, llvm/clang,
> >> hugs98, ats-lang-anairiats.
> >> 2. I'm going to help review new/updated formulae in pull requests. At
> >> least at the beginning, I will only sign off the simple and trivial
> ones,
> >> e.g. 2587, 2588, 2658, 2683, 2694, 2699, 2670.
> >> 3. I'm not especially interested in improving homebrew core. If I have
> any
> >> patch against Library/Homebrew, and bin/brew, I won't commit directly.
> I'll
> >> issue pull requests like previously, e.g. this and this, for you guys to
> >> review and sign off.
> >> 4. Any other responsibilities/plans of me are open to discuss.
> >> I really hope I can be a collaborator of Homebrew. It's my honor to help
> >> make Homebrew, the most forked software in GitHub, a great example of
> open
> >> source collaboration, better and better day to day! Thanks.
> >>
> >> --
> >> Best Regards,
> >> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> >> tianyicui@gmail.com
> >> +86 13958103659 (It's a prime number!)
> >> http://www.google.com/profiles/tianyicui
> >>
> >
> >
> >
> > --
> > Best Regards,
> > 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> > tianyicui@gmail.com
> > +86 13958103659 (It's a prime number!)
> > http://www.google.com/profiles/tianyicui
> >
>
> I'll try to look at this when I get a chance.
> What may be helpful is for you to create a new branch called
> "ready-to-merge" (or something like that), and keep those updates you
> think are ready to go specifically in that branch, and keep it rebased
> against master.
>
> For bigger changes, those need to stay in separate branches for now;
> for instance, I haven't had time to review the LLVM changes, but I
> also don't feel comfortable reviewing them since I personally don't
> build LLVM from source.
>
> So I guess make the "ready-to-merge" branch with the less
> controversial changes and I'll work through them (and comment) as I
> get time.
>
> Thanks for your patience.
>



-- 
Best Regards,
崔添翼 (Tianyi Cui, a.k.a. dd_engi)
tianyicui@gmail.com
+86 13958103659 (It's a prime number!)
http://www.google.com/profiles/tianyicui

On 18 November 2010 09:02, Tianyi Cui <tianyicui@gmail.com> wrote:
> Homebrew is getting more and more pull requests these days. And it seems
all the burden of review and sign-off them is on Adam currently. I really 
want to devote my time and help (of course only the simple and trivial 
ones at the beginning). Could we speed up the process of introducing me as
a collaborator a little bit? Thanks.

I do them too sometimes, as does Max. Your enthusiasm is great but I
don't think there's a huge rush unless Adam is unhappy with the
current situation.

--
Mike McQuaid
http://mikemcquaid.com

I completely agree with you. I should "s/all the burden/most the burden". I
also do not think there's a huge rush. I'm just trying to offer help and
enthusiastically wait for being accepted.

Tianyi Cui

On Thu, Nov 18, 2010 at 5:08 PM, Mike McQuaid <mike@mikemcquaid.com> wrote:

> On 18 November 2010 09:02, Tianyi Cui <tianyicui@gmail.com> wrote:
> > Homebrew is getting more and more pull requests these days. And it seems
> all the burden of review and sign-off them is on Adam currently. I really
> want to devote my time and help (of course only the simple and trivial ones
> at the beginning). Could we speed up the process of introducing me as a
> collaborator a little bit? Thanks.
>
> I do them too sometimes, as does Max. Your enthusiasm is great but I
> don't think there's a huge rush unless Adam is unhappy with the
> current situation.
>
> --
> Mike McQuaid
> http://mikemcquaid.com
>

        
        We need to offer more comments on commits until you're up to 
standard.Obviously it is important for us not to allow people in if they 
aren't ready. I've seen projects die that way.I note that I haven't 
reviewed your commits, sorry, I'll try.MaxI completely agree with you. I 
should "s/all the burden/most the burden". I also do not think there's a 
huge rush. I'm just trying to offer help and enthusiastically wait for 
being accepted.

Tianyi CuiOn Thu, Nov 18, 2010 at 5:08 PM, Mike McQuaid 
<mike@mikemcquaid.com> wrote:

On 18 November 2010 09:02, Tianyi Cui <tianyicui@gmail.com> wrote:
> Homebrew is getting more and more pull requests these days. And it seems
all the burden of review and sign-off them is on Adam currently. I really 
want to devote my time and help (of course only the simple and trivial 
ones at the beginning). Could we speed up the process of introducing me as
a collaborator a little bit? Thanks.



I do them too sometimes, as does Max. Your enthusiasm is great but I
don't think there's a huge rush unless Adam is unhappy with the
current situation.

--
Mike McQuaid
http://mikemcquaid.com


			
			
			
			
        
		
		
    

Yes Max I fully understand your position and can't agree more. To be clear,
I was NOT blaming or ranting. Just want to express my enthusiasm. Thanks.

On Thu, Nov 18, 2010 at 7:27 PM, Max Howell <max@methylblue.com> wrote:

>  We need to offer more comments on commits until you're up to standard.
>
> Obviously it is important for us not to allow people in if they aren't
> ready. I've seen projects die that way.
>
> I note that I haven't reviewed your commits, sorry, I'll try.
>
> Max
>
> I completely agree with you. I should "s/all the burden/most the burden". I
> also do not think there's a huge rush. I'm just trying to offer help and
> enthusiastically wait for being accepted.
>
> Tianyi Cui
>
> On Thu, Nov 18, 2010 at 5:08 PM, Mike McQuaid <mike@mikemcquaid.com>wrote:
>
> On 18 November 2010 09:02, Tianyi Cui <tianyicui@gmail.com> wrote:
> > Homebrew is getting more and more pull requests these days. And it seems
> all the burden of review and sign-off them is on Adam currently. I really
> want to devote my time and help (of course only the simple and trivial ones
> at the beginning). Could we speed up the process of introducing me as a
> collaborator a little bit? Thanks.
>
> I do them too sometimes, as does Max. Your enthusiasm is great but I
> don't think there's a huge rush unless Adam is unhappy with the
> current situation.
>
> --
> Mike McQuaid
> http://mikemcquaid.com
>
>
>
>
>


-- 
Best Regards,
崔添翼 (Tianyi Cui, a.k.a. dd_engi)
tianyicui@gmail.com
+86 13958103659 (It's a prime number!)
http://www.google.com/profiles/tianyicui

        
        Yes Max I fully understand your position and can't agree more. To 
be clear, I was NOT blaming or ranting. Just want to express 
my enthusiasm. Thanks.Oh indeed, I didn't get that impression :)I'll make 
an effort to review some stuff today.Max

OK. I break my changes into several branches:

* ready-to-merge <https://github.com/tianyicui/homebrew/tree/ready-to-merge>:
less controversial changes, IMO all are trivial new and updated formulae
* review/llvm <https://github.com/tianyicui/homebrew/tree/review/llvm>: my
refactored LLVM formula
* review/r <https://github.com/tianyicui/homebrew/tree/review/r>: R
depends_on gfortran
* review/ats <https://github.com/tianyicui/homebrew/tree/review/ats>: a
non-trivial new formula
* review/https <https://github.com/tianyicui/homebrew/tree/review/https>:
use https for all GitHub URLs

On Tue, Nov 16, 2010 at 5:01 AM, Adam Vandenberg <flangy@gmail.com> wrote:

> On Sun, Nov 14, 2010 at 11:32 PM, Tianyi Cui <tianyicui@gmail.com> wrote:
> > It's been two weeks now. In this induction period, I've done following
> > things:
> > * integrate my previous work on the LLVM formula (670ad402)
> > * new formulae: jacl, ats-lang-anairiats, clozure-cl.
> > * make `brew install r` work out of the box (e217aa54)
> > * a sbcl 1.0.43 formula without downloading binary from 3rd party
> (3f0e95d6)
> > * minor updates for formulae: gfortran, swi-prolog, plt-racket.
> > * sign-off a user-contributed formula: mit-scheme and fix its build
> error.
> > * make all GitHub links in formulae use https (41ab9eec)
> > * make all depends_on of "cmake" be marked as :build (a921062d)
> > * rebase my tree everyday based on mxcl/master to make sure it can be
> merged
> > cleanly.
> > * make sure my tree can be rebased on mxcl/refactor with little conflicts
> > (tianyicui/refactor).
> > Please review my commits (see also: GitHub Compare View). Thanks.
> > On Wed, Nov 3, 2010 at 11:34 PM, Max Howell <max@methylblue.com> wrote:
> >>
> >> Hey Tianyi,
> >>
> >> You sound extremely qualified and your areas of expertise sound
> especially
> >> useful. We have discussed how to introduce new collaborators and have
> >> decided the healthiest choice for the project is to give you a two week
> >> induction period where we review your collaborative efforts and give
> advice
> >> as necessary as to Homebrew style. After this period we'll add you as a
> >> collaborator and just ask that you take care while you get to grips with
> >> being such an important member of the project.
> >>
> >> During the induction period please cherry-pick or rebase contributions
> >> into your master branch and keep them rebased on top of mxcl/master.
> We'll
> >> merge in your contributions after review.
> >>
> >> Thanks and welcome to the team! :)
> >>
> >> Max
> >>
> >> PS. Do you have a Twitter alias?
> >>
> >> Hello everyone, esp. Max & Adam,
> >> I'm Tianyi Cui (github). I want to be a collaborator of Homebrew, so I
> can
> >> contribute to it more.
> >> My background:
> >> 1. I'm a college student, my academic interests are compilers and
> >> programming languages (esp. functional ones), that means I have a
> working
> >> knowledge on software like LLVM, Clang, Lisp (various dialects),
> >> Haskell, OCaml, etc.
> >> 2. I've been actively contributing to Homebrew in the previous weeks. In
> >> fact, I'm very likely being the one who issue the greatest numbers of
> pull
> >> requests 2.0 to it (disclaimer: I haven't really been counting the
> number).
> >> 3. Any questions related to my abilities/background are welcome.
> >> My plan:
> >> 1. I'm going to continue to contribute mainly on formulae related to my
> >> academic fields, e.g. libsigsegv, clisp, newlisp, libffi, llvm/clang,
> >> hugs98, ats-lang-anairiats.
> >> 2. I'm going to help review new/updated formulae in pull requests. At
> >> least at the beginning, I will only sign off the simple and trivial
> ones,
> >> e.g. 2587, 2588, 2658, 2683, 2694, 2699, 2670.
> >> 3. I'm not especially interested in improving homebrew core. If I have
> any
> >> patch against Library/Homebrew, and bin/brew, I won't commit directly.
> I'll
> >> issue pull requests like previously, e.g. this and this, for you guys to
> >> review and sign off.
> >> 4. Any other responsibilities/plans of me are open to discuss.
> >> I really hope I can be a collaborator of Homebrew. It's my honor to help
> >> make Homebrew, the most forked software in GitHub, a great example of
> open
> >> source collaboration, better and better day to day! Thanks.
> >>
> >> --
> >> Best Regards,
> >> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> >> tianyicui@gmail.com
> >> +86 13958103659 (It's a prime number!)
> >> http://www.google.com/profiles/tianyicui
> >>
> >
> >
> >
> > --
> > Best Regards,
> > 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> > tianyicui@gmail.com
> > +86 13958103659 (It's a prime number!)
> > http://www.google.com/profiles/tianyicui
> >
>
> I'll try to look at this when I get a chance.
> What may be helpful is for you to create a new branch called
> "ready-to-merge" (or something like that), and keep those updates you
> think are ready to go specifically in that branch, and keep it rebased
> against master.
>
> For bigger changes, those need to stay in separate branches for now;
> for instance, I haven't had time to review the LLVM changes, but I
> also don't feel comfortable reviewing them since I personally don't
> build LLVM from source.
>
> So I guess make the "ready-to-merge" branch with the less
> controversial changes and I'll work through them (and comment) as I
> get time.
>
> Thanks for your patience.
>



-- 
Best Regards,
崔添翼 (Tianyi Cui, a.k.a. dd_engi)
tianyicui@gmail.com
+86 13958103659 (It's a prime number!)
http://www.google.com/profiles/tianyicui

The https item is already in the pull request queue on mxcl - did you redo it?

On 16 November 2010 06:24, Tianyi Cui <tianyicui@gmail.com> wrote:
> OK. I break my changes into several branches:
> * ready-to-merge: less controversial changes, IMO all are trivial new and
> updated formulae
> * review/llvm: my refactored LLVM formula
> * review/r: R depends_on gfortran
> * review/ats: a non-trivial new formula
> * review/https: use https for all GitHub URLs
> On Tue, Nov 16, 2010 at 5:01 AM, Adam Vandenberg <flangy@gmail.com> wrote:
>>
>> On Sun, Nov 14, 2010 at 11:32 PM, Tianyi Cui <tianyicui@gmail.com> wrote:
>> > It's been two weeks now. In this induction period, I've done following
>> > things:
>> > * integrate my previous work on the LLVM formula (670ad402)
>> > * new formulae: jacl, ats-lang-anairiats, clozure-cl.
>> > * make `brew install r` work out of the box (e217aa54)
>> > * a sbcl 1.0.43 formula without downloading binary from 3rd party
>> > (3f0e95d6)
>> > * minor updates for formulae: gfortran, swi-prolog, plt-racket.
>> > * sign-off a user-contributed formula: mit-scheme and fix its build
>> > error.
>> > * make all GitHub links in formulae use https (41ab9eec)
>> > * make all depends_on of "cmake" be marked as :build (a921062d)
>> > * rebase my tree everyday based on mxcl/master to make sure it can be
>> > merged
>> > cleanly.
>> > * make sure my tree can be rebased on mxcl/refactor with little
>> > conflicts
>> > (tianyicui/refactor).
>> > Please review my commits (see also: GitHub Compare View). Thanks.
>> > On Wed, Nov 3, 2010 at 11:34 PM, Max Howell <max@methylblue.com> wrote:
>> >>
>> >> Hey Tianyi,
>> >>
>> >> You sound extremely qualified and your areas of expertise sound
>> >> especially
>> >> useful. We have discussed how to introduce new collaborators and have
>> >> decided the healthiest choice for the project is to give you a two week
>> >> induction period where we review your collaborative efforts and give
>> >> advice
>> >> as necessary as to Homebrew style. After this period we'll add you as a
>> >> collaborator and just ask that you take care while you get to grips
>> >> with
>> >> being such an important member of the project.
>> >>
>> >> During the induction period please cherry-pick or rebase contributions
>> >> into your master branch and keep them rebased on top of mxcl/master.
>> >> We'll
>> >> merge in your contributions after review.
>> >>
>> >> Thanks and welcome to the team! :)
>> >>
>> >> Max
>> >>
>> >> PS. Do you have a Twitter alias?
>> >>
>> >> Hello everyone, esp. Max & Adam,
>> >> I'm Tianyi Cui (github). I want to be a collaborator of Homebrew, so I
>> >> can
>> >> contribute to it more.
>> >> My background:
>> >> 1. I'm a college student, my academic interests are compilers and
>> >> programming languages (esp. functional ones), that means I have a
>> >> working
>> >> knowledge on software like LLVM, Clang, Lisp (various dialects),
>> >> Haskell, OCaml, etc.
>> >> 2. I've been actively contributing to Homebrew in the previous weeks.
>> >> In
>> >> fact, I'm very likely being the one who issue the greatest numbers of
>> >> pull
>> >> requests 2.0 to it (disclaimer: I haven't really been counting the
>> >> number).
>> >> 3. Any questions related to my abilities/background are welcome.
>> >> My plan:
>> >> 1. I'm going to continue to contribute mainly on formulae related to my
>> >> academic fields, e.g. libsigsegv, clisp, newlisp, libffi, llvm/clang,
>> >> hugs98, ats-lang-anairiats.
>> >> 2. I'm going to help review new/updated formulae in pull requests. At
>> >> least at the beginning, I will only sign off the simple and trivial
>> >> ones,
>> >> e.g. 2587, 2588, 2658, 2683, 2694, 2699, 2670.
>> >> 3. I'm not especially interested in improving homebrew core. If I have
>> >> any
>> >> patch against Library/Homebrew, and bin/brew, I won't commit directly.
>> >> I'll
>> >> issue pull requests like previously, e.g. this and this, for you guys
>> >> to
>> >> review and sign off.
>> >> 4. Any other responsibilities/plans of me are open to discuss.
>> >> I really hope I can be a collaborator of Homebrew. It's my honor to
>> >> help
>> >> make Homebrew, the most forked software in GitHub, a great example of
>> >> open
>> >> source collaboration, better and better day to day! Thanks.
>> >>
>> >> --
>> >> Best Regards,
>> >> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
>> >> tianyicui@gmail.com
>> >> +86 13958103659 (It's a prime number!)
>> >> http://www.google.com/profiles/tianyicui
>> >>
>> >
>> >
>> >
>> > --
>> > Best Regards,
>> > 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
>> > tianyicui@gmail.com
>> > +86 13958103659 (It's a prime number!)
>> > http://www.google.com/profiles/tianyicui
>> >
>>
>> I'll try to look at this when I get a chance.
>> What may be helpful is for you to create a new branch called
>> "ready-to-merge" (or something like that), and keep those updates you
>> think are ready to go specifically in that branch, and keep it rebased
>> against master.
>>
>> For bigger changes, those need to stay in separate branches for now;
>> for instance, I haven't had time to review the LLVM changes, but I
>> also don't feel comfortable reviewing them since I personally don't
>> build LLVM from source.
>>
>> So I guess make the "ready-to-merge" branch with the less
>> controversial changes and I'll work through them (and comment) as I
>> get time.
>>
>> Thanks for your patience.
>
>
>
> --
> Best Regards,
> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> tianyicui@gmail.com
> +86 13958103659 (It's a prime number!)
> http://www.google.com/profiles/tianyicui
>

I did it without realizing there was a pull request. But my commit are more
ready to merge since it only touched Library/Formula without the core
being refactoring, and it is more complete as it also handles
gist.github.com and wiki.github.com URLs.

On Wed, Nov 17, 2010 at 4:50 AM, Lee Packham <lpackham@leenux.org.uk> wrote:

> The https item is already in the pull request queue on mxcl - did you redo
> it?
>
> On 16 November 2010 06:24, Tianyi Cui <tianyicui@gmail.com> wrote:
> > OK. I break my changes into several branches:
> > * ready-to-merge: less controversial changes, IMO all are trivial new and
> > updated formulae
> > * review/llvm: my refactored LLVM formula
> > * review/r: R depends_on gfortran
> > * review/ats: a non-trivial new formula
> > * review/https: use https for all GitHub URLs
> > On Tue, Nov 16, 2010 at 5:01 AM, Adam Vandenberg <flangy@gmail.com>
> wrote:
> >>
> >> On Sun, Nov 14, 2010 at 11:32 PM, Tianyi Cui <tianyicui@gmail.com>
> wrote:
> >> > It's been two weeks now. In this induction period, I've done following
> >> > things:
> >> > * integrate my previous work on the LLVM formula (670ad402)
> >> > * new formulae: jacl, ats-lang-anairiats, clozure-cl.
> >> > * make `brew install r` work out of the box (e217aa54)
> >> > * a sbcl 1.0.43 formula without downloading binary from 3rd party
> >> > (3f0e95d6)
> >> > * minor updates for formulae: gfortran, swi-prolog, plt-racket.
> >> > * sign-off a user-contributed formula: mit-scheme and fix its build
> >> > error.
> >> > * make all GitHub links in formulae use https (41ab9eec)
> >> > * make all depends_on of "cmake" be marked as :build (a921062d)
> >> > * rebase my tree everyday based on mxcl/master to make sure it can be
> >> > merged
> >> > cleanly.
> >> > * make sure my tree can be rebased on mxcl/refactor with little
> >> > conflicts
> >> > (tianyicui/refactor).
> >> > Please review my commits (see also: GitHub Compare View). Thanks.
> >> > On Wed, Nov 3, 2010 at 11:34 PM, Max Howell <max@methylblue.com>
> wrote:
> >> >>
> >> >> Hey Tianyi,
> >> >>
> >> >> You sound extremely qualified and your areas of expertise sound
> >> >> especially
> >> >> useful. We have discussed how to introduce new collaborators and have
> >> >> decided the healthiest choice for the project is to give you a two
> week
> >> >> induction period where we review your collaborative efforts and give
> >> >> advice
> >> >> as necessary as to Homebrew style. After this period we'll add you as
> a
> >> >> collaborator and just ask that you take care while you get to grips
> >> >> with
> >> >> being such an important member of the project.
> >> >>
> >> >> During the induction period please cherry-pick or rebase
> contributions
> >> >> into your master branch and keep them rebased on top of mxcl/master.
> >> >> We'll
> >> >> merge in your contributions after review.
> >> >>
> >> >> Thanks and welcome to the team! :)
> >> >>
> >> >> Max
> >> >>
> >> >> PS. Do you have a Twitter alias?
> >> >>
> >> >> Hello everyone, esp. Max & Adam,
> >> >> I'm Tianyi Cui (github). I want to be a collaborator of Homebrew, so
> I
> >> >> can
> >> >> contribute to it more.
> >> >> My background:
> >> >> 1. I'm a college student, my academic interests are compilers and
> >> >> programming languages (esp. functional ones), that means I have a
> >> >> working
> >> >> knowledge on software like LLVM, Clang, Lisp (various dialects),
> >> >> Haskell, OCaml, etc.
> >> >> 2. I've been actively contributing to Homebrew in the previous weeks.
> >> >> In
> >> >> fact, I'm very likely being the one who issue the greatest numbers of
> >> >> pull
> >> >> requests 2.0 to it (disclaimer: I haven't really been counting the
> >> >> number).
> >> >> 3. Any questions related to my abilities/background are welcome.
> >> >> My plan:
> >> >> 1. I'm going to continue to contribute mainly on formulae related to
> my
> >> >> academic fields, e.g. libsigsegv, clisp, newlisp, libffi, llvm/clang,
> >> >> hugs98, ats-lang-anairiats.
> >> >> 2. I'm going to help review new/updated formulae in pull requests. At
> >> >> least at the beginning, I will only sign off the simple and trivial
> >> >> ones,
> >> >> e.g. 2587, 2588, 2658, 2683, 2694, 2699, 2670.
> >> >> 3. I'm not especially interested in improving homebrew core. If I
> have
> >> >> any
> >> >> patch against Library/Homebrew, and bin/brew, I won't commit
> directly.
> >> >> I'll
> >> >> issue pull requests like previously, e.g. this and this, for you guys
> >> >> to
> >> >> review and sign off.
> >> >> 4. Any other responsibilities/plans of me are open to discuss.
> >> >> I really hope I can be a collaborator of Homebrew. It's my honor to
> >> >> help
> >> >> make Homebrew, the most forked software in GitHub, a great example of
> >> >> open
> >> >> source collaboration, better and better day to day! Thanks.
> >> >>
> >> >> --
> >> >> Best Regards,
> >> >> 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> >> >> tianyicui@gmail.com
> >> >> +86 13958103659 (It's a prime number!)
> >> >> http://www.google.com/profiles/tianyicui
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Best Regards,
> >> > 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> >> > tianyicui@gmail.com
> >> > +86 13958103659 (It's a prime number!)
> >> > http://www.google.com/profiles/tianyicui
> >> >
> >>
> >> I'll try to look at this when I get a chance.
> >> What may be helpful is for you to create a new branch called
> >> "ready-to-merge" (or something like that), and keep those updates you
> >> think are ready to go specifically in that branch, and keep it rebased
> >> against master.
> >>
> >> For bigger changes, those need to stay in separate branches for now;
> >> for instance, I haven't had time to review the LLVM changes, but I
> >> also don't feel comfortable reviewing them since I personally don't
> >> build LLVM from source.
> >>
> >> So I guess make the "ready-to-merge" branch with the less
> >> controversial changes and I'll work through them (and comment) as I
> >> get time.
> >>
> >> Thanks for your patience.
> >
> >
> >
> > --
> > Best Regards,
> > 崔添翼 (Tianyi Cui, a.k.a. dd_engi)
> > tianyicui@gmail.com
> > +86 13958103659 (It's a prime number!)
> > http://www.google.com/profiles/tianyicui
> >
>



-- 
Best Regards,
崔添翼 (Tianyi Cui, a.k.a. dd_engi)
tianyicui@gmail.com
+86 13958103659 (It's a prime number!)
http://www.google.com/profiles/tianyicui