librelist archives

« back to archive

hg-review and hgweb

hg-review and hgweb

From:
David Wink
Date:
2011-03-03 @ 19:26
We use hgweb here and would love to start using hg-review.  Is there any
examples of using hg-review with hgweb?


David

Re: [hg.review] hg-review and hgweb

From:
Benoît Allard
Date:
2011-03-04 @ 13:41
Hi David,

David Wink wrote:
> We use hgweb here and would love to start using hg-review.  Is there any 
> examples of using hg-review with hgweb?

Do you mean that you want to let hg-review run on your "central" server ?

I'm not sure if it's a good idea as all comments and signoff will be 
made by the user running the server, or an Anonymous account if you 
started it this way.

hg-review has no way (yet) to let you authenticate yourself before 
reviewing the changesets ...

That's why it is mostly advised to run it every time from your own 
computer, just to perform the intended review. In this case, it is not 
overlapping with the usage scenario of hgweb.

Regards
Benoit

Re: [hg.review] hg-review and hgweb

From:
Haszlakiewicz, Eric
Date:
2011-03-07 @ 16:18
>-----Original Message-----
>From: hg.review@librelist.com [mailto:hg.review@librelist.com] On Behalf Of
>
>David Wink wrote:
>> We use hgweb here and would love to start using hg-review.  Is there any
>> examples of using hg-review with hgweb?
>
>Do you mean that you want to let hg-review run on your "central" server ?
>
>I'm not sure if it's a good idea as all comments and signoff will be
>made by the user running the server, or an Anonymous account if you
>started it this way.
>
>hg-review has no way (yet) to let you authenticate yourself before
>reviewing the changesets ...

You probably don't want to build this into hg-review.  Ideally, hg-review 
would pick up whatever authentication the web server has, in a similar way
to how hgweb does.

eric