Been working on this branch: http://github.com/sbenthall/geonode/commits/mapmetadata <http://github.com/sbenthall/geonode/commits/mapmetadata>On this ticket: http://projects.opengeo.org/CAPRA/ticket/595 It's mostly JavaScript. Reviews/comments welcome. Will continue working on related tickets: http://projects.opengeo.org/CAPRA/ticket/594 http://projects.opengeo.org/CAPRA/ticket/596 <http://projects.opengeo.org/CAPRA/ticket/594> http://projects.opengeo.org/CAPRA/ticket/630 -- Sebastian Benthall OpenGeo - http://opengeo.org
On 07/12/2010 03:39 PM, Sebastian Benthall wrote: > Been working on this branch: > http://github.com/sbenthall/geonode/commits/mapmetadata > > On this ticket: > http://projects.opengeo.org/CAPRA/ticket/595 > > It's mostly JavaScript. Reviews/comments welcome. > > Will continue working on related tickets: > http://projects.opengeo.org/CAPRA/ticket/594 > http://projects.opengeo.org/CAPRA/ticket/596 > http://projects.opengeo.org/CAPRA/ticket/630 > > -- > Sebastian Benthall > OpenGeo - http://opengeo.org > The main thing I noticed looking at this was that i18n is not being used for a lot of the strings added. Haven't tried running it though. Side note (I brought this up in channel but the list is more permanent): github's branch comparison view is pretty nice, but it can only compare within a single repository. Therefore, it's a little handier for reviewers if you keep the master branch in your fork up to date when you've merged changes from origin/master into a feature branch. Otherwise, changes that are in origin/master, but not sbenthall/master, will show up in the branch comparison view. "gitk contributer/feature ^origin/master" works pretty well too, though. -- David Winslow OpenGeo - http://opengeo.org/
> > The main thing I noticed looking at this was that i18n is not being used >> for a lot of the strings added. Haven't tried running it though. > > Good call. Thanks, I'll fix those soon. -- Sebastian Benthall OpenGeo - http://opengeo.org
I added a couple of comments on GitHub. I hope I didn't miss anything, because your forked master branch is still not up to date so it's hard to compare your branch with master. -Andreas. On Jul 13, 2010, at 21:52 , Sebastian Benthall wrote: > The main thing I noticed looking at this was that i18n is not being used for a lot of the strings added. Haven't tried running it though. > > Good call. Thanks, I'll fix those soon. > > -- > Sebastian Benthall > OpenGeo - http://opengeo.org > -- Andreas Hocevar OpenGeo - http://opengeo.org/ Expert service straight from the developers.
Thanks for the reviews. My fork's master branch is now updated. On Wed, Jul 14, 2010 at 7:37 AM, Andreas Hocevar <ahocevar@opengeo.org>wrote: > I added a couple of comments on GitHub. I hope I didn't miss anything, > because your forked master branch is still not up to date so it's hard to > compare your branch with master. > > -Andreas. > > On Jul 13, 2010, at 21:52 , Sebastian Benthall wrote: > > > The main thing I noticed looking at this was that i18n is not being used > for a lot of the strings added. Haven't tried running it though. > > > > Good call. Thanks, I'll fix those soon. > > > > -- > > Sebastian Benthall > > OpenGeo - http://opengeo.org > > > > -- > Andreas Hocevar > OpenGeo - http://opengeo.org/ > Expert service straight from the developers. > > -- Sebastian Benthall OpenGeo - http://opengeo.org
As of last week, you don't have to keep your master branch in sync with the "main" repo in order to compare against it, because the github guys have introduced a cross-repository comparison view. The announcement/docs on how to use it are here: http://github.com/blog/683-cross-repository-compare-view You can also just add the repository you're interested in and use the "standard" git tools: git remote add seb git://github.com/sbenthall/geonode git fetch seb git log origin/master...seb/mapmetadata gitk origin/master...seb/mapmetadata git diff origin/master...seb/mapmetadata But of course you don't get inline comments on changesets that way. -- David Winslow OpenGeo - http://opengeo.org/ On 07/14/2010 11:03 AM, Sebastian Benthall wrote: > Thanks for the reviews. My fork's master branch is now updated. > > On Wed, Jul 14, 2010 at 7:37 AM, Andreas Hocevar <ahocevar@opengeo.org > <mailto:ahocevar@opengeo.org>> wrote: > > I added a couple of comments on GitHub. I hope I didn't miss > anything, because your forked master branch is still not up to > date so it's hard to compare your branch with master. > > -Andreas. > > On Jul 13, 2010, at 21:52 , Sebastian Benthall wrote: > > > The main thing I noticed looking at this was that i18n is not > being used for a lot of the strings added. Haven't tried running > it though. > > > > Good call. Thanks, I'll fix those soon. > > > > -- > > Sebastian Benthall > > OpenGeo - http://opengeo.org > > > > -- > Andreas Hocevar > OpenGeo - http://opengeo.org/ > Expert service straight from the developers. > > > > > -- > Sebastian Benthall > OpenGeo - http://opengeo.org >