librelist archives

home // archives //

« back to archive

exception handling in wsgi_app()

exception handling in wsgi_app()

From:
Rodrigo Moraes
Date:
2010-05-17 @ 15:14 
Hey,
I'm sure there's a reason that I miss here: why exceptions raised on
preprocess_request() and process_response() aren't caught?

thank you,
-- rodrigo

Re: [flask] exception handling in wsgi_app()

From:
Armin Ronacher
Date:
2010-05-17 @ 16:22 
Hi,

On 2010-05-17 5:14 PM, Rodrigo Moraes wrote:
> I'm sure there's a reason that I miss here: why exceptions raised on
> preprocess_request() and process_response() aren't caught?
Right now: consistency.  preprocess_request() could be caught, 
postprocess not because the return value of the error handler is passed 
to process_response().


Regards,
Armin

Re: [flask] exception handling in wsgi_app()

From:
Rodrigo Moraes
Date:
2010-05-17 @ 17:00 
On Mon, May 17, 2010 at 1:22 PM, Armin Ronacher wrote:
> Right now: consistency.  preprocess_request() could be caught,
> postprocess not because the return value of the error handler is passed
> to process_response().

Ok. Don't you think that all uncaught exceptions should be caught by
the wsgi app? Even if only for, in the case of postprocess, to return
a InternalServerError()? Not sure if it is a possibility in some
cases, but I'm scared about the idea of tracebacks spitting in the
response.

-- rodrigo

Re: [flask] exception handling in wsgi_app()

From:
Rodrigo Moraes
Date:
2010-05-18 @ 17:38 
Ah, I was going to make a fork and discovered that this was addressed
on 
http://github.com/mitsuhiko/flask/commit/ea5e654e9e19aab5089f9a71e679bcca11581e86#L7R1181

very clean. :)
-- rodrigo

Re: [flask] exception handling in wsgi_app()

From:
Armin Ronacher
Date:
2010-05-18 @ 20:39 
Hi,

On 2010-05-18 7:38 PM, Rodrigo Moraes wrote:
> Ah, I was going to make a fork and discovered that this was addressed
Sorry, totally forgot to give feedback.


Regards,
Armin

Archives based on code by Armin Ronacher //